1447632 - Artifact builds on try server must contain accessible.tlb

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Marco Zehe (:MarcoZ)]

When creating try builds using artifact builds, accessible.tlb is not included in the resulting target.zip file. As a result, accessibility is not working properly when running such a build with a screen reader such as NVDA. if I just copy over an accessible.tlb from a regular nightly, it'll start to work. As an example of a try build with broken accessibility, see https://treeherder.mozilla.org/#/jobs?repo=try&revision=55523803881cb60675d1144da46d9e8170ce20b1

Comment 1

[James Teh [:Jamie]]

For reference, Accessible.tlb is generated in accessible/ipc/win/typelib. I'm not sure what's required to make this be considered an artifact for the purposes of artifact builds.

Comment 2

[(not currently active) Ted Mielczarek]

This should be easy to fix. Unfortunately the artifact build code currently has a list of file patterns that it uses to unpack a build into an objdir (which is separate from the list of things we use to package up the contents of dist/bin). The list for Windows builds is here:
https://dxr.mozilla.org/mozilla-central/rev/6ff60a083701d08c52702daf50f28e8f46ae3a1c/python/mozbuild/mozbuild/artifacts.py#421

Comment 3

[Marco Zehe (:MarcoZ)]

Attachment: Bug 1447632 - Make sure that TLB files are included in Windows artifact builds, .mielczarek

Review commit: https://reviewboard.mozilla.org/r/229816/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/229816/

Comment 4

[(not currently active) Ted Mielczarek]

Comment on attachment 8961060 [details]
Bug 1447632 - Make sure that TLB files are included in Windows artifact builds, .mielczarek

https://reviewboard.mozilla.org/r/229816/#review235598

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9f270d21aef5
Make sure that TLB files are included in Windows artifact builds, r=ted.mielczarek

Comment 6

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/9f270d21aef5