Closed Bug 1447639 Opened 6 years ago Closed 6 years ago

Align exception stacktrace in console with ones in Error rep

Categories

(DevTools :: Console, enhancement)

enhancement
Not set
normal

Tracking

(firefox61 fixed)

RESOLVED FIXED
Firefox 61
Tracking Status
firefox61 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

References

Details

Attachments

(3 files)

This is also an ongoing work on the Reps side (see https://github.com/devtools-html/devtools-core/issues/958). On Reps, we'll use the same colors as in mozilla-central since they were carefully chosen to work well under any themes and background we might have.

In mozilla-central, we need to add the lambda (λ) sign which is used in Reps and in the debugger Outline view.
We also need to put the location right next to the function name, while keeping them aligned, e.g.

> λ functionName  mysource.js:12:3
> λ short         mysource.js:12:3

instead of what we have now (source aligned to the right of the screen, which might be hard to parse on a large screen).
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Attached image error_vs_exception.png
Here's how it look with the patch I'm working on.
I also removed the border around the stacktrace which felt unecessary.
The overflow mechanism still works as expected and was also ported into Error Rep stacktrace.
The netmonitor, which also uses the stacktrace component, is fine as far as I can tell.
The frame locations seem to be (still) aligned to the right, but it makes the indentation wrong.

See the screenshot and section NOW. The two frames are not using the same indentation from the function name.

Honza
Flags: needinfo?(nchevobbe)
Yes, it needed some work on netmonitor css. I think now everything is fine.
Flags: needinfo?(nchevobbe)
Comment on attachment 8960941 [details]
Bug 1447639 - Small visual alignment on stacktrace; .

https://reviewboard.mozilla.org/r/229682/#review235802

Looks good now, thanks Nicolas!

R+

Honza
Attachment #8960941 - Flags: review?(odvarko) → review+
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e6e0de58de27
Small visual alignment on stacktrace; r=Honza.
https://hg.mozilla.org/mozilla-central/rev/e6e0de58de27
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: