1447669 - Add localconfig parameter for changing shadowdb user and pass

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, enhancement, P1)

Description

[Dylan Hardison [:dylan] (he/him)]

So currently the shadowdb always uses the same db_user and db_pass of the main database.

https://github.com/mozilla-bteam/bmo/blob/master/Bugzilla/DB.pm#L111-L117


what needs to be done:

- add localconfig options shadowdb_user, shadowdb_pass to Bugzilla/Install/Localconfig.pm
- add descriptions of those options to template/en/default/setup/strings.txt.pl, look near line 248 for examples
- modify Bugzilla/DB.pm connect_shadow() so that $connect_params->{db_user} = Bugzilla->{localconfig}->{shadowdb_user} if shadowdb_user is set, and the same for db_pass and shadowdb_pass.

Comment 1

[Israel Madueme [:imadueme]]

Attachment: Github PR - #489

Comment 2

[Dylan Hardison [:dylan] (he/him)]

Attachment: PR

When I wrote the param override stuff, I didn't update Bugzilla.pm to check the overriden param value for shadowdb. This corrects that mistake.