Closed Bug 1447669 Opened 2 years ago Closed 2 years ago

Add localconfig parameter for changing shadowdb user and pass

Categories

(bugzilla.mozilla.org :: General, enhancement, P1)

Production
enhancement

Tracking

()

RESOLVED FIXED

People

(Reporter: dylan, Assigned: imadueme)

References

Details

Attachments

(2 files)

45 bytes, text/x-github-pull-request
imadueme
: review+
Details | Review
PR
45 bytes, text/x-github-pull-request
Details | Review
So currently the shadowdb always uses the same db_user and db_pass of the main database.

https://github.com/mozilla-bteam/bmo/blob/master/Bugzilla/DB.pm#L111-L117


what needs to be done:

- add localconfig options shadowdb_user, shadowdb_pass to Bugzilla/Install/Localconfig.pm
- add descriptions of those options to template/en/default/setup/strings.txt.pl, look near line 248 for examples
- modify Bugzilla/DB.pm connect_shadow() so that $connect_params->{db_user} = Bugzilla->{localconfig}->{shadowdb_user} if shadowdb_user is set, and the same for db_pass and shadowdb_pass.
Attached file Github PR - #489
Attachment #8961135 - Flags: review?(dylan)
Attachment #8961135 - Flags: review?(dylan) → review+
Attached file PR
When I wrote the param override stuff, I didn't update Bugzilla.pm to check the overriden param value for shadowdb. This corrects that mistake.
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.