Closed
Bug 1447705
Opened 6 years ago
Closed 6 years ago
Make BackgroundPageThumbs._destroy actually called
Categories
(Toolkit :: General, enhancement)
Toolkit
General
Tracking
()
RESOLVED
FIXED
mozilla61
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | fixed |
People
(Reporter: peterv, Assigned: peterv)
Details
Attachments
(1 file)
|
2.06 KB,
patch
|
kmag
:
review+
|
Details | Diff | Splinter Review |
Bug 1399646 added a profile-before-change observer to BackgroundPageThumbs.jsm, but the code to register it wasn't hooked up. I've seen leaks coming from this code just starting up and shutting down (not sure if it's something in my profile), and registering the observer cleaned them up.
|
Assignee | |
Comment 1•6 years ago
|
||
Attachment #8961006 -
Flags: review?(kmaglione+bmo)
|
||
Comment 2•6 years ago
|
||
Comment on attachment 8961006 [details] [diff] [review] v1 Review of attachment 8961006 [details] [diff] [review]: ----------------------------------------------------------------- Thanks
Attachment #8961006 -
Flags: review?(kmaglione+bmo) → review+
|
|
Assignee | |
Comment 3•6 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/ccdf91217b3c6e386a357e0db863b59a952b12ac Bug 1447705 - Make BackgroundPageThumbs._destroy actually called. Fix leak from BackgroundPageThumbs.jsm. r=kmag.
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/ccdf91217b3c
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•