Closed Bug 1447715 Opened 4 years ago Closed 4 years ago

Remove old-event-emitter usage from sourceeditor

Categories

(DevTools :: Source Editor, enhancement)

enhancement
Not set
normal

Tracking

(firefox61 fixed)

RESOLVED FIXED
Firefox 61
Tracking Status
firefox61 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

References

Details

Attachments

(1 file)

No description provided.
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Comment on attachment 8961030 [details]
Bug 1447715 - Remove old-event-emitter usage from sourceeditor; .

https://reviewboard.mozilla.org/r/229782/#review235630

::: devtools/client/debugger/test/mochitest/browser_dbg_breakpoints-editor.js:73
(Diff revision 1)
>      let editorBreakpointChanges = 0;
>  
> -    function onEditorBreakpointAddFirst(aEvent, aLine) {
> +    function onEditorBreakpointAddFirst(aLine) {
>        editorBreakpointChanges++;
>  
> -      ok(aEvent,
> +      ok(true,

I think we should convert these ok(true, "..") to info("..") since this is effectively what is happening.
Attachment #8961030 - Flags: review?(gl) → review+
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a960a84b2297
Remove old-event-emitter usage from sourceeditor; r=gl.
https://hg.mozilla.org/mozilla-central/rev/a960a84b2297
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.