1447715 - Remove old-event-emitter usage from sourceeditor

Status: RESOLVED FIXED

(DevTools :: Source Editor, enhancement)

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1447715 - Remove old-event-emitter usage from sourceeditor; .

Review commit: https://reviewboard.mozilla.org/r/229782/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/229782/

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8961030 [details]
Bug 1447715 - Remove old-event-emitter usage from sourceeditor; .

https://reviewboard.mozilla.org/r/229782/#review235630

::: devtools/client/debugger/test/mochitest/browser_dbg_breakpoints-editor.js:73
(Diff revision 1)
>      let editorBreakpointChanges = 0;
>  
> -    function onEditorBreakpointAddFirst(aEvent, aLine) {
> +    function onEditorBreakpointAddFirst(aLine) {
>        editorBreakpointChanges++;
>  
> -      ok(aEvent,
> +      ok(true,

I think we should convert these ok(true, "..") to info("..") since this is effectively what is happening.

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8961030 [details]
Bug 1447715 - Remove old-event-emitter usage from sourceeditor; .

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/229782/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a960a84b2297
Remove old-event-emitter usage from sourceeditor; r=gl.

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/a960a84b2297