1447763 - Revert MSVC workarounds in the JS engine that are no longer needed

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P3)

Description

[Ryan VanderMeulen [:RyanVM]]

I've been iterating on a patch to remove most of the MSVC-specific workarounds in JS code that no longer appear to be needed. I've been aggressively testing on Try and no obvious issues have appeared.

https://treeherder.mozilla.org/#/jobs?repo=try&author=[e-mail]&fromchange=32a392688c2b79e051959bdb2da0115cc435eee1&tochange=7b3b830e85eee21bdfb3abddc3e1d2ce94ca8757

Obviously a careful review would be good here, though. For the ones that had obvious bugs associated with them, I made sure to the best of my ability that those issues didn't re-appear.

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Attachment: remove crufty MSVC compiler workarounds

Jan already gave an IRC blessing to the SharedIC.cpp and jsmath.cpp changes, but tagging him for review for posterity. Waldo, can you please look over the rest?

Comment 2

[Jeff Walden [:Waldo]]

Comment on attachment 8961074 [details] [diff] [review]
remove crufty MSVC compiler workarounds

Review of attachment 8961074 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jslibmath.h
@@ +27,5 @@
>  #else
>  #define js_copysign copysign
>  #endif
>  
>  /* Consistency wrapper for platform deviations in fmod() */

If this isn't the case any more, get rid of js_fmod entirely and use fmod at all two call sites of this, please.

Comment 3

[Jan de Mooij [:jandem]]

Comment on attachment 8961074 [details] [diff] [review]
remove crufty MSVC compiler workarounds

Review of attachment 8961074 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/64276e10f596
Remove some MSVC workarounds in the JS engine that aren't needed anymore. r=Waldo, r=jandem

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/64276e10f596