1447800 - upgrade to aiohttp 3.1.0

Status: RESOLVED FIXED

(Release Engineering Graveyard :: Applications: Balrog (backend), enhancement, P1)

Description

[[e-mail] (:bhearsum)]

pyup submitted a pull request for this (https://github.com/mozilla/balrog/pull/513), and it caused a bunch of test failures like:
___________________________ TestBalrogClient.testGET ___________________________

self = <balrogagent.test.test_client.TestBalrogClient testMethod=testGET>

    async def testGET(self):
        mocked_resp = {
            "count": 2,
            "scheduled_changes": [
                {
                    "sc_id": 1,
                    "when": 123456789,
                },
                {
                    "sc_id": 2,
                    "telemetry_product": "Firefox",
                    "telemetry_channel": "release",
                    "telemetry_uptake": 3000,
                },
            ],
        }
        with asynctest.patch("aiohttp.request", fake_request(mocked_resp, 200)) as r:
>           resp = await client.request("http://balrog.fake", "/api/scheduled_changes")

balrogagent/test/test_client.py:49: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
balrogagent/client.py:32: in request
    resp = await aiohttp.request(method, url, data=json.dumps(data), headers=headers, auth=auth, loop=loop)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <balrogagent.test.test_client.fake_request object at 0x7f853ef75748>
method = 'GET', url = 'http://balrog.fake/api/scheduled_changes', data = '{}'
kwargs = {'auth': None, 'headers': {'Accept': 'application/json', 'Accept-Encoding': 'application/json', 'Content-Type': 'application/json'}, 'loop': None}

    async def __call__(self, method, url, data={}, **kwargs):
        if url.endswith("csrf_token"):
            self.csrf_resp = aiohttp.client.ClientResponse("HEAD", URL("http://balrog.fake/api/csrf_token"))
            self.csrf_resp.headers = {"X-CSRF-Token": "foo"}
            self.csrf_resp.status = 200
            return self.csrf_resp
        else:
            self.request_data = data
>           resp = aiohttp.client.ClientResponse(method, URL(url))
E           TypeError: __init__() missing 8 required keyword-only arguments: 'writer', 'continue100', 'timer', 'request_info', 'auto_decompress', 'traces', 'loop', and 'session'

balrogagent/test/test_client.py:24: TypeError

It looks like we're calling ClientResponse wrong in some tests.

Comment 1

[[github robot]]

Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/2b76e69f1414187dd972c3ee266a13292d646385
bug 1447800: Update aiohttp to 3.1.1 & python 3.6 (#513)

Comment 2

[[e-mail] (:bhearsum)]

Now in production, and working fine.