1447830 - JS Type error on opening attendees dialog (Input is null)

Status: RESOLVED FIXED

(Calendar :: Dialogs, defect)

Description

[Markus Adrario [:Taraman]]

Full error message:
>TypeError: input is null[Learn More]  calendar-event-dialog-attendees.xml:199:1
>	appendAttendee chrome://calendar/content/calendar-event-dialog-attendees.xml:199:1
>	onInitialize chrome://calendar/content/calendar-event-dialog-attendees.xml:160:17
>	onLoad chrome://calendar/content/calendar-event-dialog-attendees.xml:81:13
>	onLoad self-hosted:975:17
>	editAttendees chrome://lightning/content/lightning-item-iframe.js:1835:5
>	receiveMessage chrome://lightning/content/lightning-item-iframe.js:189:31

Introduced in Nightly Build: 2018-03-15-03-02-01-comm-central/ [1]

Most likely caused by bug463402



[1]: https://ftp.mozilla.org/pub/thunderbird/nightly/2018/03/2018-03-15-03-02-01-comm-central/

Comment 1

[[:MakeMyDay]]

I haven't looked at the issue itself, but I don't think this is a regression from bug 463402. There hasn't been a change in this file or the attendee dialog at all from these patches and I have all patches applied on top of changeset 1cb55e399e91 (a few pushed before the landed chahnegsets of bug 463402) and I cannot reproduce the reported behaviour in this setup - regardless of having or not an email identity associated to the calendar. It's more likely we're suffering from an mc change here.

Comment 2

[[:MakeMyDay]]

This is likely a fallout of 1444580, but I haven't proved by backing out that change, though.

Comment 3

[[:MakeMyDay]]

Can somebody please check whether or not this is an issue in 60b1/6.2b1, too?

Comment 4

[Stefan Sitter [:ssitter]]

I don't see the error using Lightning 6.2b1 (BuildID 20180323052656).

Comment 5

[Stefan Sitter [:ssitter]]

According to comment 1 the regression range would be 

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=deb7714a7bcd3448952440e92d0209abec6b886d&tochange=68dfe5ee5b80ee99b7e389d739a30089f6f1e55d

https://hg.mozilla.org/comm-central/pushloghtml?fromchange=9bd75170c7aea42af5de3c7de1da9ff9a0b84354&tochange=fc57e733b75a63884cc171f2b8256497ef7c0148

Might be caused by Bug 1443948 that changed something about xbl bindings and attaching them to the document. And calendar-event-dialog-attendees.xml is a xbl binding.

Comment 6

[[:MakeMyDay]]

Unblocking bug 1414612 since this is not an issue in 6.2 based on comment 4.

Comment 7

[Markus Adrario [:Taraman]]

Brian, can you maybe help to find out if this is indeed related to Bug 1443948 as speculated in comment 5?
And maybe even give a hint, how this can be fixed...

Debugging shows that at [1], the getAnonymousElementByAttribute() calls do not return anything.

[1]: https://dxr.mozilla.org/comm-central/rev/304145e6e1ce10ddab2fc911a1a98e397cab816e/calendar/base/content/dialogs/calendar-event-dialog-attendees.xml#180

Comment 8

[Brian Grinstead [:bgrins]]

(In reply to Markus Adrario [:Taraman] from comment #7)
> Brian, can you maybe help to find out if this is indeed related to Bug
> 1443948 as speculated in comment 5?
> And maybe even give a hint, how this can be fixed...
> 
> Debugging shows that at [1], the getAnonymousElementByAttribute() calls do
> not return anything.
> 
> [1]:
> https://dxr.mozilla.org/comm-central/rev/
> 304145e6e1ce10ddab2fc911a1a98e397cab816e/calendar/base/content/dialogs/
> calendar-event-dialog-attendees.xml#180

Yeah this looks exactly like something that Bug 1443948 would have broken. Before, the binding would get attached to the cloned node (even though it wasn't in the document and thus didn't match the CSS selector needed to attach -moz-binding). Now, you'd need to do `aParentNode.appendChild(newNode);` to cause the XBL binding to get attached to `newNode` and make things like `document.getAnonymousElementByAttribute` work.

Comment 9

[Markus Adrario [:Taraman]]

Thanks Brian, I will give it a try.
Since Lightning is not wworking currently I cannot test, but I stay on it.

Comment 10

[[:MakeMyDay]]

Attachment: FixAttendeeDialog-V1.diff

This is a band-aid patch that brings at least the capability to add or remove attendees back. Freebusy has still some flaws and the background-color vanished.  

Since Wayne is pushing for a beta and adding attendees wouldn't work without this patch, we should take that for now and follow-up.

Comment 11

[[:MakeMyDay]]

The flaws I mentioned in comment 10 are related to the use of listboxes, which will be removed with 1477478. I mark this bug to depend on it with regard to the user experience, though technically the reported issue is already fixed here.

Comment 12

[Jorg K (CEST = GMT+2)]

(In reply to [:MakeMyDay] from comment #10)
> Since Wayne is pushing for a beta and adding attendees wouldn't work without
> this patch, we should take that for now and follow-up.
I don't understand how Wayne can be pushing for beta 62. Calendar will *not* work on beta since the overlay loader conflicts with the native overlay loader that was discontinued at mozilla63. Check the beta tree to see that it's full of failures.

This is a discussion we should have elsewhere, but I had to mention it.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/9d5db359adf0
Make attendee dialog usable again (band-aid patch). r=philipp

Comment 14

[Jorg K (CEST = GMT+2)]

Comment on attachment 8993496 [details] [diff] [review]
FixAttendeeDialog-V1.diff

TB 62 beta won't happen.