Closed
Bug 1447835
Opened 6 years ago
Closed 6 years ago
Remove unneeded MSVC compiler warning suppressions
Categories
(Core :: JavaScript Engine, enhancement, P3)
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: RyanVM, Assigned: RyanVM)
Details
Attachments
(1 file)
8.93 KB,
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
We have a number of MSVC warning suppressions that don't appear to be needed anymore. At least, I don't get any Werror bustage on Try :)
Assignee | ||
Comment 1•6 years ago
|
||
This is green on Try, so I guess that means it works :) A couple comments: * I removed the -we options from moz.build because we build with -W3, and all of those warnings are Level 1 or 2 and therefore covered anyway. * wd4146 and wd4312 both look reasonably fixable, but are out of scope for this bug.
Attachment #8961211 -
Flags: review?(jwalden+bmo)
Updated•6 years ago
|
Priority: -- → P3
Updated•6 years ago
|
Attachment #8961211 -
Flags: review?(jwalden+bmo) → review+
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/736c81fc596c Remove JS MSVC warning suppressions which are no longer needed. r=Waldo
Comment 3•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/736c81fc596c
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•