1447907 - Port bug 1429875 to TB: Windows: MapiProxy.lib : fatal error LNK1120: 5 unresolved externals, Linux, Mac: Link errors related to libical.

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Richard Marti (:Paenglab)]

See log: https://treeherder.mozilla.org/logviewer.html#?job_id=169575532&repo=comm-central&lineNumber=5978
or on Linux https://treeherder.mozilla.org/logviewer.html#?job_id=169580285&repo=comm-central&lineNumber=28539

Local build without bug 1429875 builds successful.

Comment 1

[Jorg K (CEST = GMT+2)]

For Linux/Mac you see the problem a few lines above
https://treeherder.mozilla.org/logviewer.html#?job_id=169580285&repo=comm-central&lineNumber=28539

INFO -  /builds/worker/workspace/build/src/comm/calendar/base/backend/libical/calICSService.cpp:356: undefined reference to `icalvalue_get_datetime'
and many more.

Or on Mac:
INFO -        _icalvalue_new_from_string_with_error in Unified_c_libical_src_libical1.o
INFO -  ld: symbol(s) not found for architecture x86_64
and many more.

Comment 2

[Jorg K (CEST = GMT+2)]

Attachment: 1447907-linkage.patch

Patch received from Philipp via IRC.

Try with M-C at f82d56c64966 to avoid bustage from bug 1447940:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=9075c6294d33cca92e8397ca434c9ee12656860a

Comment 3

[Richard Marti (:Paenglab)]

This fixes ical and probably Linux and Mac. On Windows there is still:

 1:14.86 MapiProxy.dll
 1:14.98 MapiProxy.def : error LNK2001: unresolved external symbol DllCanUnloadNow
 1:14.98 MapiProxy.def : error LNK2001: unresolved external symbol DllGetClassObject
 1:14.98 MapiProxy.def : error LNK2001: unresolved external symbol DllRegisterServer
 1:14.98 MapiProxy.def : error LNK2001: unresolved external symbol DllUnregisterServer
 1:14.98 MapiProxy.def : error LNK2001: unresolved external symbol GetProxyDllInfo
 1:14.98 MapiProxy.lib : fatal error LNK1120: 5 unresolved externals

Comment 4

[Jorg K (CEST = GMT+2)]

That's expected. It's Philipp's WIP.

Comment 5

[Jorg K (CEST = GMT+2)]

OK, that works on Mac, so landing what we have.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f44cfb13e72d
Port bug 1429875 to TB: re-write linkage logic in moz.build. rs=bustage-fix DONTBUILD CLOSED TREE

Comment 7

[Jorg K (CEST = GMT+2)]

Great job, Philipp. We still need the MAPI stuff, but this got us going again!!

Comment 8

[Jorg K (CEST = GMT+2)]

Attachment: win.patch

Patch supplied by Philipp via IRC.

This goes further, but gives:
 4:29.95 msgMapiImp.obj : error LNK2001: unresolved external symbol IID_nsIMapi
 4:29.95 xul.dll : fatal error LNK1120: 1 unresolved externals

The problem appears to be that msgMapi_i.c which is created from msgMapi.idl is not used when building msgMapiImp.obj.

The next hack addresses that. Only for those who want to build again.

Comment 9

[Jorg K (CEST = GMT+2)]

Attachment: win-hack.patch

Comment 10

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: MAPI Fix - v1

Comment 11

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

If you would like to defer the review to a build person please go ahead, but I suspect you'll be landing this with rs=bustage-fix anyway.

Comment 12

[Jorg K (CEST = GMT+2)]

Comment on attachment 8961701 [details] [diff] [review]
MAPI Fix - v1

Thanks for attending to this quickly. I'm really quite unqualified as a reviewer since I don't understand any of this magic. For example, what do the ! do in the SOURCES? Maybe they tell the system not to check for those files up-front because they are generated during the process?

I tried it and it works for me, thanks again.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e58b200fabf3
Adapt link logic for mapi component. rs=jorgk,bustage-fix

Comment 14

[Jorg K (CEST = GMT+2)]

Philipp, if you want another review, please request it. We sometimes have to land follow-ups in bustage fix cases, but at least we're back to a manageable state where others can work.