144796 - bug_email.pl does not use the default qa-contact

Status: RESOLVED INVALID

(Bugzilla :: Bugzilla-General, defect, P3)

Description

[Jussi Sirpoma]

When submitting new bugs with the bug_email.pl and there is no @qa_contact field
defined in the email, the default qa-contact is not assigned to the bug.

In case it is relevant, I had defined the following fields in the email:

@version, @product, @component, @op_sys and @rep_platform

Comment 1

[Jussi Sirpoma]

When trying to set the qa-contact by using the @qa_contact field in the email,
bug_email tried to insert it as a login name and not as a userid. 

I had set the bug_email into test mode to see what the sql statement was:

insert into bugs ( product, version, rep_platform, bug_severity, priority,
op_sys, assigned_to, short_desc, component, qa_contact, reporter, bug_status,
creation_ts, everconfirmed) values ( 'VisualStage', '0.8', 'PC', 'normal', 'P3',
'Windows 2000', '3', 'test bug xxx', 'Bugmail', '[e-mail]', '1', 'NEW',
'2002-05-15 20:06:31', 1)

Comment 2

[Andreas Franke (gone)]

That's probably because bug_email.pl is not part of the core bugzilla, but in
the contrib directory instead, thus it has suffered some bitrot over time.
As always, patches are welcome, and I think offers for active maintainership are
appreciated as well. :-)

Hm, which version are you using? Looking at the cvs log of bug_email.pl at
http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/webtools/bugzilla/contrib/bug_email.pl
the last checkin comment says (Rev. 1.9, jake%acutex.net, May 25 2001):

	Bug 79739 - Initial Owner and QA Contact were not being handled
	correctly by the email interface after they were changed to userid's 
	in bug 66876. r= [e-mail]

Maybe there is more to be done wrt. initial QA Contacts...

Comment 3

[Jussi Sirpoma]

Attachment: fix for both the default qa and the qa_contact keyword issue

Since I needed the fuctionality and made a fix for myself, I'll attach the
patch here. You could find this useful.

I have tested it and at least in my installation, it does fix these issues. I
have a few other modifications in the bug_email.pl, but they are not related to
these problems. (bug 139735)

Comment 4

[Jussi Sirpoma]

Attachment: Patch v2

As a side note, it's annoying that bugzilla does not allow me to obsolete my
own patch... :)

Comment 5

[Jussi Sirpoma]

Attachment: Retry of patch v2

smbd and nfs had different opinion about the contents of the file, so here it
is again... Sorry for the spam.

Comment 6

[Jouni Heikniemi]

Comment on attachment 84064 [details] [diff] [review]
Retry of patch v2

>+    if( defined( $Control{'qa_contact'} ) ) {
>+        $qacontact = DBname_to_id($Control{'qa_contact'});
>+    }
...
>+    if( $qacontact == 0)
>+    {

You are using two different block opening conventions here. 
The Bugzilla style guide advises using the following style:

if ($qacontact == 0) {
    # BLOCK
}

>+        SendSQL("select initialqacontact from components where program=" .
>+                SqlQuote($Control{'product'}) .
>+                " and value=" . SqlQuote($Control{'component'}));

While you're fixing the previous one, you could uppercase the SQL keywords
here as well (SELECT, FROM, WHERE, AND). Spacing around the operators is
an established convention, too.

Comment 7

[Jussi Sirpoma]

Attachment: Patch v3

Fixes the convention issues.

Comment 8

[Dave Miller [:justdave]]

CCing Dan Berlin, who from stuff I've seen around, I know is actually using the
bug_email stuff.  I'd appreciate any input or fixes you'd be willing to provide
on these bugs :-)

Comment 9

[Dave Miller [:justdave]]

I was pushing the bug_email stuff out to 2.20, but this has a patch on it
waiting for review.

Dan, it's got you tagged...  have a few minutes to look at it or want it passed
off to someone else?

Comment 10

[Dave Miller [:justdave]]

Pushing out bugs that aren't blockers.  If someone's working on one of these, we
can move it back.

Comment 11

[Shane H. W. Travis]

Comment on attachment 84074 [details] [diff] [review]
Patch v3

Not surprisingly, in two years this patch has bitrotted... probably because we
now use product_id and the removed text has changed. I'm betting tht it
wouldn't take much to fix it up, though, as not a lot of other peopel do work
in this area... 

Jussi, are you still interested in getting this onto the trunk? If so, please
say as much and I'll try and help you with the process (and reviews) as much --
and as quickly -- as I can.

(First step would be to get the patch in such a state that it applies to the
tip.)

Comment 12

[Shane H. W. Travis]

Adding myself and a couple of other active, helpful people to the cc: list.

Comment 13

[Shane H. W. Travis]

Comment on attachment 83893 [details] [diff] [review]
fix for both the default qa and the qa_contact keyword issue

Obsoleting old patch.

Comment 14

[Daniel Berlin]

Sigh.
Apparently, my bugzilla.mozilla.org email was getting thrown into my spam filter,
so i never noticed i was tagged for this email.

In the meantime, our bug_email code has grown and changed, and as time goes on,
people have been using it less and less (though people use bugzilla_email_append
more and more).
As such, i'm not sure i can be of much help here anymore, as we more or less
consider bugzilla email based interfaces to not be very useful.
The main complaint people had was that there was no way to use bugzilla without
opening a web browser.
That I've solved a different way, through using an XMLRPC interface, like redhat
has (in fact, it's based on redhats).
It's easy for me to make XMLRPC clients that do whatever people want, in various
languages, and they generally are happy to use them instead of email.
There are always stragglers (we have one gccc person who still uses mail from bsd
4.3lite, which doesn't add various headers necessary for threading), but they've
diminished to the point where they don't even make up a vocal minority. 

Comment 15

[Max Kanat-Alexander]

This bug has not been touched by its owner in over six months, even though it is
targeted to 2.20, for which the freeze is 10 days away. Unsetting the target
milestone, on the assumption that nobody is actually working on it or has any
plans to soon.

If you are the owner, and you plan to work on the bug, please give it a real
target milestone. If you are the owner, and you do *not* plan to work on it,
please reassign it to [e-mail] or a .bugs component owner. If you are
*anybody*, and you get this comment, and *you* plan to work on the bug, please
reassign it to yourself if you have the ability.

Comment 16

[Frédéric Buclin]

It's exactly the opposite: the default QA contact is used even if you specify
one! I have opened bug 293901.