1447961 - bustage at dom/base/nsGlobalWindowInner.cpp:3054:32: error: 'cx' was not declared in this scope when Gecko 61 merges to Beta on 2018-04-26

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

central-as-beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d5e183284736fd75a4a93e40d317342e55eec615&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable&group_state=expanded&selectedJob=169626611

Apply the 2 top most patches if you want to push to Try.

Log: https://treeherder.mozilla.org/logviewer.html#?job_id=169626611&repo=try

[task 2018-03-22T10:25:28.048Z] 10:25:28     INFO -  /builds/worker/workspace/build/src/dom/base/nsGlobalWindowInner.cpp: In member function 'bool nsGlobalWindowInner::DoResolve(JSContext*, JS::Handle<JSObject*>, JS::Handle<jsid>, JS::MutableHandle<JS::PropertyDescriptor>)':
[task 2018-03-22T10:25:28.049Z] 10:25:28     INFO -  /builds/worker/workspace/build/src/dom/base/nsGlobalWindowInner.cpp:3054:32: error: 'cx' was not declared in this scope
[task 2018-03-22T10:25:28.049Z] 10:25:28     INFO -       JS::Rooted<JSObject*> shim(cx, JS_NewObject(cx, clazz));

Failing code got added as part of bug 1062418 here: https://hg.mozilla.org/mozilla-central/rev/f36074b39330#l3.199

Comment 1

[Boris Zbarsky [:bzbarsky]]

Oh, this code isn't even compiled on nightly, right.  And I didn't fix it up enough when moving it over, since it wasn't being compiled...

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix the beta-and-release-only components shim code to actually compile

MozReview-Commit-ID: AreiVNKWg5L

Comment 3

[Boris Zbarsky [:bzbarsky]]

> Fix the beta-and-release-only components shim code to actually compile

_controllers_ shim.  I fixed that locally.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/20ecf59cea1b
Fix the beta-and-release-only controllers shim code to actually compile.  r=mystor

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/20ecf59cea1b

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Thank you, verified fixed in the latest central-as-beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&revision=62fff771b6a6ffadea4f7383c0986f0e5f4f2cda&group_state=expanded&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable

Comment 7

[Tarek Ziadé (:tarek)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=40e30024dfb47908280a56be97f5db7108ac2424

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

The patches need to be rebased on a recent mozilla-central revision. That Try pushes uses a mozilla-central revision from a week ago as base: https://hg.mozilla.org/mozilla-central/rev/de32269720d0

Comment 9

[Tarek Ziadé (:tarek)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=837b88a71a5391da42097ab3eaa2f6cde650e249

Comment 10

[Tarek Ziadé (:tarek)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d45c44f744b8edd8ee2ead89312da05c7cae1c08

Comment 11

[Tarek Ziadé (:tarek)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cc5fb11cc37d6ea29728affe7e9ed2fff67a00ae