Closed Bug 1447972 Opened 3 years ago Closed 3 years ago

Missing full stop period at end of "Choose what you see when… and new tabs"

Categories

(Firefox :: New Tab Page, defect, P2)

61 Branch
defect

Tracking

()

RESOLVED FIXED
Firefox 61
Iteration:
61.2 - Apr 9
Tracking Status
firefox59 --- unaffected
firefox60 --- unaffected
firefox61 --- fixed

People

(Reporter: winson.wen1, Assigned: rrosario)

References

(Blocks 1 open bug)

Details

(Whiteboard: [strings m-c landed])

Attachments

(2 files)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0
Build ID: 20180321220044

Steps to reproduce:

Open about:preferences
Click on the Home tab


Actual results:

Drop-down menus are different lengths
"(Default)" text in drop-down menus aren't grey/faded
No colon after "Homepage and new windows" and "New tabs"


Expected results:

Drop-down menus are the same length
"(Default)" text in drop-down menus is grey/faded
Colon after "Homepage and new windows" and "New tabs"

As per https://mozilla.invisionapp.com/share/EGFI16P8Y36#/screens/280785532
Also full-stop missing at the end of "Choose what you see when you open your homepage, new windows, and new tabs"
Attached image Capture.PNG
Also, gap between header ans description should be consistent.
Sorry for spam, forgot to include this in the original comment
Blocks: 1417155
Has Regression Range: --- → irrelevant
Has STR: --- → yes
Component: Untriaged → Activity Streams: Newtab
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Unspecified → All
Hardware: Unspecified → All
The colon was removed to match the rest of about:preferences as per 1417155 comment 36.

Bug 1447988 covers the width.

Design is good with non-gray "(Default)" if it's not supported easily, which seems like it would require a new xbl binding to have double <xul:label>s differently styled: https://searchfox.org/mozilla-central/source/toolkit/content/widgets/menu.xml#180-187

So the remaining issue is the full stop.

k88hudson, do you know if it was intentionally omitted?
Flags: needinfo?(khudson)
Summary: Home preferences don't match spec → Missing full stop period at end of "Choose what you see when… and new tabs"
The full stop was not intentionally omitted – it should probably be consistent at least across our other sections in about:preferences#home. I think this should be fixed
Flags: needinfo?(khudson)
flod, this punctuation addition should require an id change to trigger relocalization?
Flags: needinfo?(francesco.lodolo)
Whiteboard: [strings m-c needed]
(In reply to Ed Lee :Mardak from comment #5)
> flod, this punctuation addition should require an id change to trigger
> relocalization?

Yes, if you want to ensure that all locales notice the change and adapt their translation, you need a new ID. For punctuation, most locales follow English, so it's good to change the ID.
Flags: needinfo?(francesco.lodolo)
Blocks: 1432589
Iteration: --- → 61.2 - Apr 9
Priority: -- → P2
Assignee: nobody → rrosario
Comment on attachment 8964670 [details]
Bug 1447972 - Missing full stop period in home page preferences

gandalf, any differences with ftl for string changes?
Attachment #8964670 - Flags: review?(edilee) → review?(gandalf)
We are working toward a bit more sophisticated model which will only require ID change when semantics of the message changes.

In the new model we may be able to distinguish stylistic change from en-US specific spelling/punctuation change, which would be helpful here.

My gut feeling is that it is ok to leave the ID, but I'll NI flod for confirmation.
Flags: needinfo?(francesco.lodolo)
We need the new ID if we want consistency in the UI.

Most locales follow blindly en-US when it comes to punctuation. Result: English is inconsistent, only 8 locales don't have the issue (consciously or not)

https://transvision.mozfr.org/string/?entity=browser/browser/preferences/preferences.ftl:home-new-windows-tabs-description&repo=gecko_strings
Flags: needinfo?(francesco.lodolo)
Comment on attachment 8964670 [details]
Bug 1447972 - Missing full stop period in home page preferences

https://reviewboard.mozilla.org/r/233360/#review239114

Ok, this is a great example of the planned string versioning feature then. Until that gets enabled, let's keep changing the ID even in such cases (my heart bleeds a little) :(
Attachment #8964670 - Flags: review?(gandalf) → review+
Pushed by edilee@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/1d7c8c50aeab
Missing full stop period in home page preferences r=gandalf
https://hg.mozilla.org/mozilla-central/rev/1d7c8c50aeab
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Whiteboard: [strings m-c needed] → [strings m-c landed]
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.