1447975 - Sentence case and second person not used for accept cookies until setting

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect, P5)

Description

[Winson Wen]

Attachment: Capture.PNG

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0
Build ID: 20180321220044

Steps to reproduce:

Open about:preferences
Click on Privacy & Security tab


Actual results:

The "Keep until" drop-down under cookies and site data uses first person "I close Nightly" and "they expire" is in lower case instead of sentence case.


Expected results:

First person should be changed to third person or second person to be consistent with the rest of preferences. For example "Keep until You close Nightly" or "Keep until Nightly is closed".
"they expire" should be "They expire" to be consistent with other drop-downs in preferences.

Comment 1

[Sam Foster [:sfoster] (he/him)]

Michelle, this is an easy fix - at least for en-US - if this sounds ok to you?

Comment 2

[mheubusch]

It does sound ok.  Thanks for the careful attention to these details!  Please use "They expire" and "Nightly is closed"

Comment 3

[Sam Foster [:sfoster] (he/him)]

Is browser/locales/en-US/chrome/browser/preferences/privacy.dtd#56 going to be the right place to fix this? AIUI we are in the process of converting preferences strings over to Fluent, so I don't want to mark this as a good-first-bug if its a moving target?

Comment 4

[Francesco Lodolo [:flod]]

It's definitely a moving target: there's a patch in review in bug 1446180 for the privacy pane.

Maybe mark this as blocked and flag it as good-first-bug later?

Comment 5

[Zibi Braniecki [:zbraniecki][:gandalf]]

or I could also fix it in bug 1446180 and save us a string update later ;)

Comment 6

[Francesco Lodolo [:flod]]

(In reply to Zibi Braniecki [:gandalf][:zibi] from comment #5)
> or I could also fix it in bug 1446180 and save us a string update later ;)

That would work for me (we'll need to avoid migrating the string from "I close Nightly").

Comment 7

[Sam Foster [:sfoster] (he/him)]

Either plan works for me. I'll mark it as blocked by bug 1446180 for now.

Comment 8

[Zibi Braniecki [:zbraniecki][:gandalf]]

Can you provide the old->new string? I'll add it to my patch and remove the migration.

Comment 9

[Francesco Lodolo [:flod]]

I'll add them in MozReview.

Comment 10

[Francesco Lodolo [:flod]]

Fixed as part of bug 1446180
https://hg.mozilla.org/mozilla-central/rev/6f4319fc1bd2