Closed Bug 1448023 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 10029 - idlharness.js: Distinguish instance toJSON is being executed against when it's inherited

Categories

(Testing :: web-platform-tests, defect, P4)

defect

Tracking

(firefox61 fixed)

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: wptsync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 10029 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/w3c/web-platform-tests/pull/10029
Details from upstream follow.

Luke Bjerring <lukebjerring@chromium.org> wrote:
>  idlharness.js: Distinguish instance toJSON is being executed against when it's inherited
>  
>  The specific 'bug' that I am attempting to fix is outlined in https://github.com/w3c/web-platform-tests/pull/9787
>  
>  I am unsure why changing `[Default] toJSON();` to `[Default] object toJSON();` suddenly results in the new error:
>  
>      3 duplicate test names: "Test default toJSON operation of DOMPointReadOnly", "Test default toJSON 
>      operation of DOMRectReadOnly", "Test default toJSON operation of DOMMatrixReadOnly"
>  
>  I _have_ clarified that the duplication occurs from running the test on both `DOMMatrix` and `DOMMatrixReadOnly`, where `DOMMatrix : DOMMatrixReadOnly`.
>  `this.name` is `DOMMatrixReadOnly` in both cases, in spite of the idlArray object instance being DOMMatrix.
>  
>  
>
Ran 107 tests and 20225 subtests
OK     : 105
PASS   : 17377
FAIL   : 2847
TIMEOUT: 3

Existing tests that now have a worse result (e.g. they used to PASS and now FAIL):
/webrtc/interfaces.https.html
    Main test driver: FAIL
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1f5dac710487
[wpt PR 10029] - idlharness.js: Distinguish instance toJSON is being executed against when it's inherited, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/5fba803bc951
[wpt PR 10029] - Update wpt metadata, a=testonly
https://hg.mozilla.org/mozilla-central/rev/1f5dac710487
https://hg.mozilla.org/mozilla-central/rev/5fba803bc951
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.