1448026 - TEST-UNEXPECTED-FAIL | [snip]/mozmill/content-tabs/test-about-support.js | test-about-support.js::test_copy_to_clipboard_public

Status: RESOLVED FIXED

(Thunderbird :: General, enhancement)

Description

[Jorg K (CEST = GMT+2)]

See here:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=9075c6294d33cca92e8397ca434c9ee12656860a

INFO -  SUMMARY-UNEXPECTED-FAIL | test-about-support.js | test-about-support.js::test_copy_to_clipboard_public
INFO -    EXCEPTION: Found "undefined" in flavor "text/unicode"

INFO -  SUMMARY-UNEXPECTED-FAIL | test-about-support.js | test-about-support.js::test_copy_to_clipboard_private
INFO -    EXCEPTION: Found "undefined" in flavor "text/unicode"

Or maybe we need to port something.

Comment 1

[Jorg K (CEST = GMT+2)]

Oops, did I just report a duplicate of bug 1373809? I've never seen this on Mac.

Comment 2

[Richard Marti (:Paenglab)]

I have only a port of bug 1440573 in my queue that I know has changed in aboutSupport. I'm waiting until the policies shim bug lands for this one.

Comment 3

[Jorg K (CEST = GMT+2)]

Well, this is new:
M-C last good: 3aa5d07146382
M-C first bad, try run based on M-C rev f82d56c64966:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=3aa5d07146382&tochange=f82d56c64966

I'm sure Aceman can find it.

Comment 4

[:aceman]

In bug 1447611 they removed info about Stylo support from Troubleshoting.jsm. about:troubleshooting now shows Stylo content=undefined, chrome=undefined. Our tests check for this :)
This output is also in Firefox Nightly, so it seems they forgot to remove the Stylo display from aboutSupport.xhtml/.js yet. We should watch when they make that change to port it.

I'll see why the test didn't catch this already in test_display_about_support() which also checks for "undefined".

Comment 5

[:aceman]

(In reply to :aceman from comment #4)
> I'll see why the test didn't catch this already in
> test_display_about_support() which also checks for "undefined".

Looks like I intentionally did this change in the past that this test only checks if the whole value of an element (e.g. a table cell) equals 'undefined' or 'null', not if it just contains it. The other tests that fail now do check if the string is included anywhere in text.

So it looks like the tests are fine as they are.

Comment 6

[:aceman]

Attachment: 1448026.patch

You can either land this to fix the test (and m-c can port it :)), disable the test, or wait for what toolkit comes up so we can port it.

We want to have exact code in this file to what m-c has so even if we land our version first and they make their patch slightly different, we will then sync us to them.

Comment 7

[Jorg K (CEST = GMT+2)]

Comment on attachment 8961576 [details] [diff] [review]
1448026.patch

That's exactly what bug 1448173 is removing. Thanks!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/08a17fa4b78b
Port bug 1448173: remove Stylo information from aboutSupport.*. r=jorgk

Comment 9

[Jorg K (CEST = GMT+2)]

Sorry about the hasty landing and re-badging that as port when M-C removed more code. My mistake.

Comment 10

[:aceman]

Attachment: 1448026-2.patch

Removed the leftover function to sync with the m-c patch.

Comment 11

[Jorg K (CEST = GMT+2)]

Comment on attachment 8961590 [details] [diff] [review]
1448026-2.patch

Thanks, sorry about the extra hassle.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8f0bfcf717a0
Port bug 1448173: remove getReasonStringName() from aboutSupport.js. r=jorgk