Closed
Bug 1448028
Opened 6 years ago
Closed 6 years ago
use third-party path list for implicit constructor checks
Categories
(Developer Infrastructure :: Source Code Analysis, enhancement)
Developer Infrastructure
Source Code Analysis
Tracking
(firefox61 fixed)
RESOLVED
FIXED
mozilla61
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
Details
Attachments
(1 file)
|
3.83 KB,
patch
|
andi
:
review+
|
Details | Diff | Splinter Review |
The check for whether an implicit constructor is in a third-party directory currently has a homegrown list of directories to ignore. Let's move this over to the (more complete!) list of third-party directories maintained elsewhere.
|
Assignee | |
Comment 1•6 years ago
|
||
Attachment #8961426 -
Flags: review?(bpostelnicu)
|
||
Comment 2•6 years ago
|
||
\o/
|
||
Comment 3•6 years ago
|
||
The patch looks good to me, I've tested it locally but i wanna make sure we don't regress here, so I've fired a try job: https://treeherder.mozilla.org/#/jobs?repo=try&revision=cdae30f3e21c38eb008530c0574a212f7a4568c3
|
|
||
Comment 4•6 years ago
|
||
Comment on attachment 8961426 [details] [diff] [review] use third-party path list for implicit constructor checks https://treeherder.mozilla.org/#/jobs?repo=try&revision=e087b7239c21248f29da1ae9ed3294f186df15ce&selectedJob=170540864
Attachment #8961426 -
Flags: review?(bpostelnicu) → review+
Pushed by nfroyd@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/49a4227bf927 use third-party path list for implicit constructor checks; r=andi
|
||
Comment 6•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/49a4227bf927
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
|
||
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•