Closed Bug 1448028 Opened 2 years ago Closed 2 years ago

use third-party path list for implicit constructor checks

Categories

(Firefox Build System :: Source Code Analysis, enhancement)

enhancement
Not set

Tracking

(firefox61 fixed)

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: froydnj, Assigned: froydnj)

Details

Attachments

(1 file)

The check for whether an implicit constructor is in a third-party
directory currently has a homegrown list of directories to ignore.
Let's move this over to the (more complete!) list of third-party
directories maintained elsewhere.
The patch looks good to me, I've tested it locally but i wanna make sure we don't regress here, so I've fired a try job: https://treeherder.mozilla.org/#/jobs?repo=try&revision=cdae30f3e21c38eb008530c0574a212f7a4568c3
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/49a4227bf927
use third-party path list for implicit constructor checks; r=andi
https://hg.mozilla.org/mozilla-central/rev/49a4227bf927
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.