Closed Bug 1448033 Opened 6 years ago Closed 6 years ago

Update the progress of downloading an update more than every 500ms

Categories

(Toolkit :: Application Update, enhancement)

Product:
Toolkit
Component:
Application Update
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla61
Tracking Flags:
Tracking Status
firefox61 --- fixed

People

(Reporter: florian, Assigned: florian)

Details

(Whiteboard: [fxperf:p1])

Attachments

(1 file)

Patch
1.10 KB, patch
mcmanus
: review+
Details | Diff | Splinter Review 
When opening the about dialog to see the progress of downloading an update, the value is updated every 500ms, which means that when updating Firefox over a fast connection, the value displayed jumps by a few MB at once.

Given that this isn't an animated progress bar but just a text label, I don't think we need to update this at 60fps, but doing it every 100ms would probably look nicer.
Attached patch Patch — — Splinter Review 
The existing 500ms was set in bug 316071 where my concern at the time was that for slow connections the update wasn't frequent enough when waiting for 300kB to be received. Funny that 9 years later I have the exact opposite concern that it's not updated often enough on fast connections :-).
Attachment #8961435 - Flags: review?(mcmanus)
Assignee: nobody → florian
Status: NEW → ASSIGNED
Whiteboard: [fxperf:p1]
Attachment #8961435 - Flags: review?(mcmanus) → review+
Pushed by florian@queze.net:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e154006c2847
Update the progress of downloading an update every 100ms, r=mcmanus.
https://hg.mozilla.org/mozilla-central/rev/e154006c2847
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox61: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: