1448061 - Improve accuracy of devtools entry points telemetry

Status: RESOLVED FIXED

(DevTools :: General, defect, P2)

Description

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

This patch will add the following labels to DEVTOOLS_ENTRY_POINT:
  - DeveloperToolbar
  - SessionRestore

It also fixes an issue where launching firefox with the --jsdebugger was not reported as "CommandLine."

Comment 1

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Bug 1448061 - Improve accuracy of devtools entry points telemetry

Review commit: https://reviewboard.mozilla.org/r/230222/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/230222/

Comment 2

[Julian Descottes [:jdescottes]]

Comment on attachment 8961461 [details]
Bug 1448061 - Improve accuracy of devtools entry points telemetry

https://reviewboard.mozilla.org/r/230222/#review236060

Looks good to me! 

One note about "DeveloperToolbar": it will only count when the toolbar re-opens itself automatically on startup. 
If a user starts devtools with the Toolbar shortcut (shift+F2), it will still be logged as a "KeyShortcut".

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dfc97e92b5e3
Improve accuracy of devtools entry points telemetry r=jdescottes

Comment 4

[:Harald Kirschner :digitarald]

We should try getting that uplifted to Beta after validating the data in Nightly.

Comment 5

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/dfc97e92b5e3

Comment 6

[:Harald Kirschner :digitarald]

Moving to M1 for splitting off M2 work.