1448074 - Enable remote connection telemetry in release channel

Status: RESOLVED FIXED

(DevTools :: General, defect, P2)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

We should track remote connection metrics in release channel to better understand how often it's used.

In particular, we should change these metrics to opt-out:

* DEVTOOLS_WEBIDE.*CONNECTION_RESULT: tracks success or failure of device connections by type
* DEVTOOLS_WEBIDE_CONNECTED_RUNTIME.*: tracks system verison and type for device connections

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Data Collection Review

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Bug 1448074 - Mark remote connection stats as opt-out. data-review=francois

Review commit: https://reviewboard.mozilla.org/r/238674/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/238674/

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a06178c907bef56b37f6088780e104b46e5d8777

Comment 4

[Julian Descottes [:jdescottes]]

Comment on attachment 8969838 [details]
Bug 1448074 - Mark remote connection stats as opt-out. data-review=francois

https://reviewboard.mozilla.org/r/238674/#review244466

Looks good to me code wise, maybe we should mention the original bug that introduced the probes in the bug_numbers array ? (ie Bug 916804 for most of them)

Comment 5

[François Marier [:francois]]

Comment on attachment 8969830 [details]
Data Collection Review

1) Is there or will there be **documentation** that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes, in Histograms.json.

2) Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, telemetry setting.

3) If the request is for permanent data collection, is there someone who will monitor the data over time?**

Yes, J. Ryan Stinnett.

4) Using the **[category system of data types](https://wiki.mozilla.org/Firefox/Data_Collection)** on the Mozilla wiki, what collection type of data do the requested measurements fall under?  **

Category 1 and 2.

5) Is the data collection request for default-on or default-off?

Default on, all channels.

6) Does the instrumentation include the addition of **any *new* identifiers** (whether anonymous or otherwise; e.g., username, random IDs, etc.  See the appendix for more details)?

No.

7) Is the data collection covered by the existing Firefox privacy notice?

Yes.

8) Does there need to be a check-in in the future to determine whether to renew the data?

No, permanent.

Comment 6

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8969838 [details]
Bug 1448074 - Mark remote connection stats as opt-out. data-review=francois

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/238674/diff/1-2/

Comment 7

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8969838 [details]
Bug 1448074 - Mark remote connection stats as opt-out. data-review=francois

https://reviewboard.mozilla.org/r/238674/#review244466

Good idea, I have added the old bug numbers.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/02dd12e4b48f
Mark remote connection stats as opt-out. data-review=francois r=jdescottes

Comment 9

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/02dd12e4b48f

Comment 10

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8969838 [details]
Bug 1448074 - Mark remote connection stats as opt-out. data-review=francois

Approval Request Comment
[Feature/Bug causing the regression]: No regression; this change only marks existing telemetry probes as opt-out for release.
[User impact if declined]: If declined, we'll need to wait one more cycle for release data.
[Is this code covered by automated tests?]: Yes.
[Has the fix been verified in Nightly?]: Yes.
[Needs manual test from QE? If yes, steps to reproduce]: No.
[List of other uplifts needed for the feature/fix]: None.
[Is the change risky?]: No.
[Why is the change risky/not risky?]: Only changes telemetry config.
[String changes made/needed]: None.

Comment 11

[Liz Henry (:lizzard)]

Comment on attachment 8969838 [details]
Bug 1448074 - Mark remote connection stats as opt-out. data-review=francois

From further discussion with the telemetry folks (georg and thuelbert) this sounds pretty low risk. Let's uplift for beta 16.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/df5b2985a111