Closed
Bug 1448074
Opened 6 years ago
Closed 6 years ago
Enable remote connection telemetry in release channel
Categories
(DevTools :: General, defect, P2)
DevTools
General
Tracking
(firefox59 wontfix, firefox60 fixed, firefox61 fixed)
RESOLVED
FIXED
Firefox 61
People
(Reporter: jryans, Assigned: jryans)
References
(Blocks 2 open bugs)
Details
Attachments
(2 files)
2.23 KB,
text/plain
|
francois
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
jdescottes
:
review+
lizzard
:
approval-mozilla-beta+
|
Details |
We should track remote connection metrics in release channel to better understand how often it's used. In particular, we should change these metrics to opt-out: * DEVTOOLS_WEBIDE.*CONNECTION_RESULT: tracks success or failure of device connections by type * DEVTOOLS_WEBIDE_CONNECTED_RUNTIME.*: tracks system verison and type for device connections
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 1•6 years ago
|
||
Attachment #8969830 -
Flags: review?(francois)
Comment hidden (mozreview-request) |
Assignee | ||
Comment 3•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a06178c907bef56b37f6088780e104b46e5d8777
Comment 4•6 years ago
|
||
mozreview-review |
Comment on attachment 8969838 [details] Bug 1448074 - Mark remote connection stats as opt-out. data-review=francois https://reviewboard.mozilla.org/r/238674/#review244466 Looks good to me code wise, maybe we should mention the original bug that introduced the probes in the bug_numbers array ? (ie Bug 916804 for most of them)
Attachment #8969838 -
Flags: review?(jdescottes) → review+
Comment 5•6 years ago
|
||
Comment on attachment 8969830 [details] Data Collection Review 1) Is there or will there be **documentation** that describes the schema for the ultimate data set available publicly, complete and accurate? Yes, in Histograms.json. 2) Is there a control mechanism that allows the user to turn the data collection on and off? Yes, telemetry setting. 3) If the request is for permanent data collection, is there someone who will monitor the data over time?** Yes, J. Ryan Stinnett. 4) Using the **[category system of data types](https://wiki.mozilla.org/Firefox/Data_Collection)** on the Mozilla wiki, what collection type of data do the requested measurements fall under? ** Category 1 and 2. 5) Is the data collection request for default-on or default-off? Default on, all channels. 6) Does the instrumentation include the addition of **any *new* identifiers** (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)? No. 7) Is the data collection covered by the existing Firefox privacy notice? Yes. 8) Does there need to be a check-in in the future to determine whether to renew the data? No, permanent.
Attachment #8969830 -
Flags: review?(francois) → review+
Comment hidden (mozreview-request) |
Assignee | ||
Comment 7•6 years ago
|
||
mozreview-review-reply |
Comment on attachment 8969838 [details] Bug 1448074 - Mark remote connection stats as opt-out. data-review=francois https://reviewboard.mozilla.org/r/238674/#review244466 Good idea, I have added the old bug numbers.
Pushed by jryans@gmail.com: https://hg.mozilla.org/integration/autoland/rev/02dd12e4b48f Mark remote connection stats as opt-out. data-review=francois r=jdescottes
Comment 9•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/02dd12e4b48f
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Assignee | ||
Comment 10•6 years ago
|
||
Comment on attachment 8969838 [details] Bug 1448074 - Mark remote connection stats as opt-out. data-review=francois Approval Request Comment [Feature/Bug causing the regression]: No regression; this change only marks existing telemetry probes as opt-out for release. [User impact if declined]: If declined, we'll need to wait one more cycle for release data. [Is this code covered by automated tests?]: Yes. [Has the fix been verified in Nightly?]: Yes. [Needs manual test from QE? If yes, steps to reproduce]: No. [List of other uplifts needed for the feature/fix]: None. [Is the change risky?]: No. [Why is the change risky/not risky?]: Only changes telemetry config. [String changes made/needed]: None.
Attachment #8969838 -
Flags: approval-mozilla-beta?
Assignee | ||
Updated•6 years ago
|
status-firefox59:
--- → wontfix
status-firefox60:
--- → affected
Comment 11•6 years ago
|
||
Comment on attachment 8969838 [details] Bug 1448074 - Mark remote connection stats as opt-out. data-review=francois From further discussion with the telemetry folks (georg and thuelbert) this sounds pretty low risk. Let's uplift for beta 16.
Attachment #8969838 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 12•6 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/df5b2985a111
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•