Closed
Bug 1448095
Opened 6 years ago
Closed 6 years ago
Fix errors (warnings) in javadoc build
Categories
(GeckoView :: General, defect, P5)
GeckoView
General
Tracking
(firefox61 fixed)
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: snorp, Assigned: jchen)
References
Details
Attachments
(2 files)
1.46 KB,
patch
|
jchen
:
review+
|
Details | Diff | Splinter Review |
7.55 KB,
patch
|
jchen
:
review+
|
Details | Diff | Splinter Review |
I get the following errors today: /home/snorp/source/gecko/mobile/android/geckoview/src/main/java/org/mozilla/geckoview/GeckoSession.java:20: error: cannot find symbol import org.mozilla.gecko.IGeckoEditableParent; ^ symbol: class IGeckoEditableParent location: package org.mozilla.gecko /home/snorp/source/gecko/mobile/android/geckoview/src/main/java/org/mozilla/geckoview/TextInputController.java:12: error: cannot find symbol import org.mozilla.gecko.IGeckoEditableParent; ^ symbol: class IGeckoEditableParent location: package org.mozilla.gecko /home/snorp/source/gecko/mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoEditable.java:47: error: package IGeckoEditableParent does not exist extends IGeckoEditableParent.Stub ^ /home/snorp/source/gecko/mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoEditableChild.java:25: error: cannot find symbol public final class GeckoEditableChild extends JNIObject implements IGeckoEditableChild { ^ symbol: class IGeckoEditableChild /home/snorp/source/gecko/mobile/android/geckoview/src/main/java/org/mozilla/geckoview/GeckoSession.java:507: error: cannot find symbol /* package */ native void attachEditable(IGeckoEditableParent parent, ^ symbol: class IGeckoEditableParent location: class Window /home/snorp/source/gecko/mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoEditable.java:70: error: cannot find symbol /* package */ IGeckoEditableChild mDefaultChild; // Used by IC thread. ^ symbol: class IGeckoEditableChild location: class GeckoEditable /home/snorp/source/gecko/mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoEditable.java:72: error: cannot find symbol /* package */ IGeckoEditableChild mFocusedChild; // Used by IC thread. ^ symbol: class IGeckoEditableChild location: class GeckoEditable /home/snorp/source/gecko/mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoEditable.java:102: error: cannot find symbol private void onKeyEvent(final IGeckoEditableChild child, KeyEvent event, int action, ^ symbol: class IGeckoEditableChild location: class GeckoEditable /home/snorp/source/gecko/mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoEditable.java:620: error: cannot find symbol public void setDefaultEditableChild(final IGeckoEditableChild child) { ^ symbol: class IGeckoEditableChild location: class GeckoEditable /home/snorp/source/gecko/mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoEditable.java:1060: error: cannot find symbol public void notifyIME(final IGeckoEditableChild child, final int type) { ^ symbol: class IGeckoEditableChild location: class GeckoEditable /home/snorp/source/gecko/mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoEditableChild.java:72: error: cannot find symbol private final IGeckoEditableParent mEditableParent; ^ symbol: class IGeckoEditableParent location: class GeckoEditableChild /home/snorp/source/gecko/mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoEditableChild.java:73: error: cannot find symbol private final IGeckoEditableChild mEditableChild; ^ symbol: class IGeckoEditableChild location: class GeckoEditableChild /home/snorp/source/gecko/mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoEditableChild.java:78: error: cannot find symbol public GeckoEditableChild(final IGeckoEditableParent editableParent) { ^ symbol: class IGeckoEditableParent location: class GeckoEditableChild /home/snorp/source/gecko/mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoEditableChild.java:30: error: package IGeckoEditableChild does not exist private final class RemoteChild extends IGeckoEditableChild.Stub { ^ /home/snorp/source/gecko/mobile/android/geckoview/src/main/java/org/mozilla/gecko/process/GeckoProcessManager.java:9: error: cannot find symbol import org.mozilla.gecko.IGeckoEditableParent; ^ symbol: class IGeckoEditableParent location: package org.mozilla.gecko /home/snorp/source/gecko/mobile/android/geckoview/src/main/java/org/mozilla/gecko/process/GeckoProcessManager.java:28: error: package IProcessManager does not exist public final class GeckoProcessManager extends IProcessManager.Stub { ^ /home/snorp/source/gecko/mobile/android/geckoview/src/main/java/org/mozilla/gecko/process/GeckoProcessManager.java:37: error: cannot find symbol private static native IGeckoEditableParent nativeGetEditableParent(long contentId, ^ symbol: class IGeckoEditableParent location: class GeckoProcessManager /home/snorp/source/gecko/mobile/android/geckoview/src/main/java/org/mozilla/gecko/process/GeckoProcessManager.java:41: error: cannot find symbol public IGeckoEditableParent getEditableParent(final long contentId, final long tabId) { ^ symbol: class IGeckoEditableParent location: class GeckoProcessManager /home/snorp/source/gecko/mobile/android/geckoview/src/main/java/org/mozilla/gecko/process/GeckoProcessManager.java:51: error: cannot find symbol private IChildProcess mChild; ^ symbol: class IChildProcess location: class ChildConnection /home/snorp/source/gecko/mobile/android/geckoview/src/main/java/org/mozilla/gecko/process/GeckoProcessManager.java:69: error: cannot find symbol public synchronized IChildProcess bind() { ^ symbol: class IChildProcess location: class ChildConnection /home/snorp/source/gecko/mobile/android/geckoview/src/main/java/org/mozilla/geckoview/GeckoSession.java:661: warning: no @param for extras public static void preload(final @NonNull Context context, ^ 21 warnings
Updated•6 years ago
|
Priority: -- → P5
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 5•6 years ago
|
||
Add AIDL output directory to javadoc source paths so AIDL classes are picked up.
Attachment #8970334 -
Flags: review+
Assignee | ||
Comment 6•6 years ago
|
||
Attachment #8970335 -
Flags: review+
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → nchen
Status: NEW → ASSIGNED
Pushed by nchen@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/ef55a35aa35e 1. Add AIDL output to javadoc source; r=me https://hg.mozilla.org/integration/mozilla-inbound/rev/6da32c5c109d 2. Fix javadoc warnings; r=me
Comment 8•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ef55a35aa35e https://hg.mozilla.org/mozilla-central/rev/6da32c5c109d
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Updated•5 years ago
|
Product: Firefox for Android → GeckoView
Updated•5 years ago
|
Target Milestone: Firefox 61 → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•