Closed Bug 1448103 Opened 7 years ago Closed 7 years ago

mp4parse doesn't build with Rust nightly

Categories

(Core :: Audio/Video: Playback, defect, P2)

defect

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: snorp, Unassigned)

Details

0:17.82 force-cargo-library-build 0:18.93 Compiling mp4parse v0.10.0 (file:///home/snorp/source/gecko/media/mp4parse-rust/mp4parse) 0:19.23 error[E0658]: use of unstable library feature 'try_reserve': new API (see issue #48043) 0:19.23 --> media/mp4parse-rust/mp4parse/src/lib.rs:59:20 0:19.23 | 0:19.23 59 | return vec.try_reserve(size); 0:19.23 | ^^^^^^^^^^^ 0:19.23 | 0:19.23 = help: add #![feature(try_reserve)] to the crate attributes to enable 0:19.23 0:19.28 error[E0308]: mismatched types 0:19.28 --> media/mp4parse-rust/mp4parse/src/lib.rs:59:16 0:19.28 | 0:19.28 59 | return vec.try_reserve(size); 0:19.28 | ^^^^^^^^^^^^^^^^^^^^^ expected (), found enum `std::collections::CollectionAllocErr` 0:19.28 | 0:19.28 = note: expected type `std::result::Result<_, ()>` 0:19.28 found type `std::result::Result<_, std::collections::CollectionAllocErr>` 0:19.28 0:19.28 error[E0658]: use of unstable library feature 'try_reserve': new API (see issue #48043) 0:19.28 --> media/mp4parse-rust/mp4parse/src/lib.rs:71:13 0:19.28 | 0:19.28 71 | buf.try_reserve(size)?; 0:19.28 | ^^^^^^^^^^^ 0:19.28 | 0:19.28 = help: add #![feature(try_reserve)] to the crate attributes to enable 0:19.28 0:19.28 error[E0277]: the trait bound `(): std::convert::From<std::collections::CollectionAllocErr>` is not satisfied 0:19.28 --> media/mp4parse-rust/mp4parse/src/lib.rs:71:9 0:19.28 | 0:19.28 71 | buf.try_reserve(size)?; 0:19.28 | ^^^^^^^^^^^^^^^^^^^^^^ the trait `std::convert::From<std::collections::CollectionAllocErr>` is not implemented for `()` 0:19.28 | 0:19.28 = note: required by `std::convert::From::from` 0:19.28 0:19.68 error: aborting due to 4 previous errors 0:19.68 0:19.68 Some errors occurred: E0277, E0308, E0658. 0:19.68 For more information about an error, try `rustc --explain E0277`. 0:19.70 error: Could not compile `mp4parse`.
James is this still a problem? Which version of Rust are/were you running?
Rank: 15
Flags: needinfo?(snorp)
Priority: -- → P2
I was using rust nightly when I filed the bug, but have since switched back to stable.
Flags: needinfo?(snorp)
(In reply to James Willcox (:snorp) (jwillcox@mozilla.com) from comment #2) > I was using rust nightly when I filed the bug, but have since switched back > to stable. I just tried with today's rust nightly and it compiled fine without any errors. Thanks for reporting though.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.