Closed
Bug 1448149
Opened 8 years ago
Closed 8 years ago
[wpt-sync] Sync PR 10148 - Do not print logs twice when running wpt lint
Categories
(Testing :: web-platform-tests, defect, P4)
Testing
web-platform-tests
Tracking
(firefox61 fixed)
RESOLVED
FIXED
mozilla61
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 10148 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/w3c/web-platform-tests/pull/10148
Details from upstream follow.
bmac <bmac325@GMail.com> wrote:
> Do not print logs twice when running wpt lint
>
> Running `wpt lint` appears to print a duplicate line to the console for each line the logger module prints.
>
>
> ### Before
> ```
> $ ./wpt lint cors/allow-headers.htm
> cors/allow-headers.htm:87: Whitespace at EOL (TRAILING WHITESPACE)
> ERROR:lint:cors/allow-headers.htm:87: Whitespace at EOL (TRAILING WHITESPACE)
>
> INFO:lint:
> There was 1 error (TRAILING WHITESPACE: 1)
> INFO:lint:There was 1 error (TRAILING WHITESPACE: 1)
> You must fix all errors; for details on how to fix them, see
> INFO:lint:You must fix all errors; for details on how to fix them, see
> http://web-platform-tests.org/writing-tests/lint-tool.html
> INFO:lint:http://web-platform-tests.org/writing-tests/lint-tool.html
>
> INFO:lint:
> However, instead of fixing a particular error, it's sometimes
> INFO:lint:However, instead of fixing a particular error, it's sometimes
> OK to add a line to the lint.whitelist file in the root of the
> INFO:lint:OK to add a line to the lint.whitelist file in the root of the
> web-platform-tests directory to make the lint tool ignore it.
> INFO:lint:web-platform-tests directory to make the lint tool ignore it.
>
> INFO:lint:
> For example, to make the lint tool ignore all 'TRAILING WHITESPACE'
> INFO:lint:For example, to make the lint tool ignore all 'TRAILING WHITESPACE'
> errors in the cors/allow-headers.htm file,
> INFO:lint:errors in the cors/allow-headers.htm file,
> you could add the following line to the lint.whitelist file.
> INFO:lint:you could add the following line to the lint.whitelist file.
>
> INFO:lint:
> TRAILING WHITESPACE: cors/allow-headers.htm
> INFO:lint:TRAILING WHITESPACE: cors/allow-headers.htm
> ```
>
> ### After
> ```
> $ ./wpt lint cors/allow-headers.htm
> cors/allow-headers.htm:87: Whitespace at EOL (TRAILING WHITESPACE)
>
> There was 1 error (TRAILING WHITESPACE: 1)
> You must fix all errors; for details on how to fix them, see
> http://web-platform-tests.org/writing-tests/lint-tool.html
>
> However, instead of fixing a particular error, it's sometimes
> OK to add a line to the lint.whitelist file in the root of the
> web-platform-tests directory to make the lint tool ignore it.
>
> For example, to make the lint tool ignore all 'TRAILING WHITESPACE'
> errors in the cors/allow-headers.htm file,
> you could add the following line to the lint.whitelist file.
>
> TRAILING WHITESPACE: cors/allow-headers.htm
> ```
| Reporter | ||
Comment 1•8 years ago
|
||
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3437d8dffc5b
[wpt PR 10148] - Do not print logs twice when running wpt lint, a=testonly
Comment 3•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•