Closed Bug 1448294 Opened 2 years ago Closed 2 years ago

Clean up naming of 'styleContext' variables after the big nsStyleContext rename

Categories

(Core :: Layout, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: jwatt, Assigned: jwatt)

References

Details

Attachments

(1 file)

No description provided.
Comment on attachment 8961711 [details]
Summary: Bug 1448294 - Clean up naming of 'styleContext' variables after the big nsStyleContext rename. r=emilio

Emilio Cobos Álvarez [:emilio] has approved the revision.

https://phabricator.services.mozilla.com/D796
Attachment #8961711 - Flags: review+
Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/180051cfe357
Summary: Bug 1448294 - Clean up naming of 'styleContext' variables after the big nsStyleContext rename. r=emilio
Backout by nbeleuzu@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9f7f97d22f07
Backed out 2 changesets (bug 1448294, bug 1448337) for wpt and reftest failures on /mathml
Pushed by ecoal95@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/142c279497d5
Clean up naming of 'styleContext' variables after the big nsStyleContext rename. r=emilio
Relanded with a trivial fix:

diff --git a/layout/mathml/nsMathMLChar.cpp b/layout/mathml/nsMathMLChar.cpp
index f360fcd997e4..f61fa20fec11 100644
--- a/layout/mathml/nsMathMLChar.cpp
+++ b/layout/mathml/nsMathMLChar.cpp
@@ -1977,6 +1977,7 @@ nsMathMLChar::Display(nsDisplayListBuilder*   aBuilder,
   if (mDraw == DRAW_NORMAL) {
     // normal drawing if there is nothing special about this char
     // Use our parent element's style
+    usingParentStyle = true;
     computedStyle = aForFrame->Style();
   }
 

Sorry for overlooking that!
(In reply to Emilio Cobos Álvarez [:emilio] from comment #6)
> Sorry for overlooking that!

You and me both. :)

Thanks for the fix.
https://hg.mozilla.org/mozilla-central/rev/142c279497d5
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.