Closed
Bug 1448320
Opened 6 years ago
Closed 6 years ago
onDetachedFront throws when receiving event
Categories
(DevTools :: Inspector: Rules, defect, P3)
DevTools
Inspector: Rules
Tracking
(firefox61 fixed)
RESOLVED
FIXED
Firefox 61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: jdescottes, Assigned: jdescottes)
References
Details
Attachments
(1 file)
TypeError: this.onSelected is not a function: onDetachedFront@resource://devtools/shared/base-loader.js -> resource://devtools/client/inspector/rules/rules.js:1659 The callback throws because onSelected is never bound in the rule view.
Comment hidden (mozreview-request) |
Assignee | ||
Comment 2•6 years ago
|
||
Regression from 1382581
Comment 3•6 years ago
|
||
mozreview-review |
Comment on attachment 8961758 [details] Bug 1448320 - bind onDetachedFront in RuleView constructor; https://reviewboard.mozilla.org/r/230612/#review236104
Attachment #8961758 -
Flags: review?(pbrosset) → review+
Assignee | ||
Comment 4•6 years ago
|
||
"The callback throws because onSelected is never bound in the rule view." Of course I meant "The callback throws because onDetachedFront is never bound in the rule view." :) Thanks for the review!
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4e884e689aad bind onDetachedFront in RuleView constructor;r=pbro
Comment 6•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4e884e689aad
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•