Closed
Bug 1448331
Opened 6 years ago
Closed 6 years ago
browser_favicon_load.js doesn't clean itself up properly, so fails in TV suite
Categories
(Core :: Networking, enhancement)
Core
Networking
Tracking
()
RESOLVED
FIXED
mozilla61
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: bzbarsky)
Details
Attachments
(1 file)
|
1.14 KB,
patch
|
mak
:
review+
|
Details | Diff | Splinter Review |
It leaves a dangling observer, which then gets called after the test has gone away and starts throwing exceptions.
|
Assignee | |
Comment 1•6 years ago
|
||
Attachment #8961775 -
Flags: review?(mak77)
|
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
|
||
Comment 2•6 years ago
|
||
Comment on attachment 8961775 [details] [diff] [review] Fix TV failures in browser_favicon_load.js Review of attachment 8961775 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!
Attachment #8961775 -
Flags: review?(mak77) → review+
Pushed by bzbarsky@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/6adf86b8d121 Fix TV failures in browser_favicon_load.js. r=mak
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/6adf86b8d121
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•