1448378 - win64-asan builds broken with: crashinject.pdb has an unexpected dependency on ../../dist/bin/crashinject.exe which breaks INSTALL_TARGETS.

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[(not currently active) Ted Mielczarek]

Specifically I think this is a bad interaction between bug 1360650 and bug 1255485. I probably wrote the patches for the latter before the former landed and forgot to update them accordingly.

This is the code that's causing the issue:
https://dxr.mozilla.org/mozilla-central/rev/6ff60a083701d08c52702daf50f28e8f46ae3a1c/config/rules.mk#822

I think the issue here is the `$(call syms_template,$(file),$(addsuffix .pdb,$(basename $(file)))`, which now winds up expanding to something like:

```
syms:: crashinject.pdb
crashinject.pdb: ../../dist/bin/crashinject.exe
ifdef MOZ_CRASHREPORTER
	$$(call py_action,dumpsymbols,$$(abspath $$<) $$(abspath $$@))
endif
```

I wonder if we can fix this by simply removing that line and instead changing the target to `syms`, like `PDB_TARGET = syms`? That way when we build the `syms` target in automation we'd wind up copying the .pdb files, but we wouldn't otherwise introduce the pdb: exe dependency.

Comment 2

[(Away)]

Attachment: Fix build and symbols for Windows ASan

Comment 3

[(Away)]

Forgot to mention: IIUC, with this change, we'll stop generating symbols packages for st-an and friends who have MOZ_AUTOMATION_BUILD_SYMBOLS=0 -- which I think is actually the desired behavior anyway.

Comment 4

[Nathan Froyd [:froydnj]]

Comment on attachment 8962454 [details] [diff] [review]
Fix build and symbols for Windows ASan

Review of attachment 8962454 [details] [diff] [review]:
-----------------------------------------------------------------

I think Ted has previously OK'd the rules.mk change (or at least said it was sensible), and the recurse.mk change seems obvious in retrospect.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4aa4e013ab72
Fix build and symbols on Windows ASan. r=froydnj

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/4aa4e013ab72