Closed Bug 1448382 Opened 2 years ago Closed 2 years ago

[Static Analysis] Add js/src/vtune/ to the ThirdPartyPaths and .clang-format-ignore

Categories

(Firefox Build System :: Source Code Analysis, enhancement)

3 Branch
enhancement
Not set
normal

Tracking

(firefox-esr60 fixed, firefox61 fixed)

RESOLVED FIXED
mozilla61
Tracking Status
firefox-esr60 --- fixed
firefox61 --- fixed

People

(Reporter: andi, Assigned: andi)

References

Details

Attachments

(1 file)

Since we don't own "js/src/vtune" and we get some errors using checker: https://bugzilla.mozilla.org/show_bug.cgi?id=1440886, we should add it to ThirdPartyPaths, thus ignoring it's content from analysis.
Attachment #8961832 - Flags: review?(sledru)
Comment on attachment 8961832 [details]
Bug 1448382 - Add js/src/vtune/ to the ThirdPartyPaths and .clang-format-ignore.

https://reviewboard.mozilla.org/r/230650/#review236198

::: commit-message-5bc91:1
(Diff revision 1)
> +Bug 1448382 - Add js/src/vtune/ to the ThirdPartyPaths. r?sylvester

you could also add it to .clang-format-ignore

::: tools/rewriting/ThirdPartyPaths.txt:26
(Diff revision 1)
>  intl/icu/
>  ipc/chromium/
>  js/src/ctypes/libffi/
>  js/src/dtoa.c
>  js/src/jit/arm64/vixl/
> +js/src/vtune/

I think js/src/vtune/VTuneWrapper.* are from Mozilla?
Attachment #8961832 - Flags: review?(sledru)
Summary: [Static Analysis] Add js/src/vtune/ to the ThirdPartyPaths → [Static Analysis] Add js/src/vtune/ to the ThirdPartyPaths and .clang-format-ignore
Comment on attachment 8961832 [details]
Bug 1448382 - Add js/src/vtune/ to the ThirdPartyPaths and .clang-format-ignore.

https://reviewboard.mozilla.org/r/230650/#review236314
Attachment #8961832 - Flags: review?(sledru) → review+
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/69c3d8d1d653
Add js/src/vtune/ to the ThirdPartyPaths and .clang-format-ignore. r=sylvestre
https://hg.mozilla.org/mozilla-central/rev/69c3d8d1d653
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Comment on attachment 8961832 [details]
Bug 1448382 - Add js/src/vtune/ to the ThirdPartyPaths and .clang-format-ignore.

[ESR Uplift Approval Request]

If this is not a sec:{high,crit} bug, please state case for ESR consideration: This is required for easier backporting of patches after the reformatting of ESR using clang-format.

User impact if declined: Declining this will negatively impact our developers' ability to easily backport their patches to ESR in the future.

Fix Landed on Version: 65

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): This is NPOTB.

String or UUID changes made by this patch: None
Attachment #8961832 - Flags: approval-mozilla-esr60?
Comment on attachment 8961832 [details]
Bug 1448382 - Add js/src/vtune/ to the ThirdPartyPaths and .clang-format-ignore.

OK for uplift to ESR for clang-format project.
Attachment #8961832 - Flags: approval-mozilla-esr60? → approval-mozilla-esr60+
Version: Version 3 → 3 Branch
You need to log in before you can comment on or make changes to this bug.