Closed
Bug 1448391
Opened 6 years ago
Closed 6 years ago
Remove pointless QI in tree's "view" getter
Categories
(Toolkit :: UI Widgets, enhancement)
Toolkit
UI Widgets
Tracking
()
RESOLVED
FIXED
mozilla61
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
Attachments
(1 file)
|
1.32 KB,
patch
|
Gijs
:
review+
|
Details | Diff | Splinter Review |
this.treeBoxObject returns either a WebIDL TreeBoxObject or an nsITreeBoxObject. In either case, .view returns a nsITreeView, so the QI there is pointless.
|
Assignee | |
Comment 1•6 years ago
|
||
Attachment #8961830 -
Flags: review?(gijskruitbosch+bugs)
|
||
Comment 2•6 years ago
|
||
Comment on attachment 8961830 [details] [diff] [review] Remove pointless QI in tree's 'view' getter Review of attachment 8961830 [details] [diff] [review]: ----------------------------------------------------------------- rs=me
Attachment #8961830 -
Flags: review?(gijskruitbosch+bugs) → review+
Pushed by bzbarsky@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/25aa56b75f67 Remove pointless QI in tree's 'view' getter. r=gijs
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/25aa56b75f67
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•