Closed Bug 1448519 Opened 3 years ago Closed 3 years ago

Pick up clang-cl bool fix in r328386

Categories

(Firefox Build System :: General, defect)

3 Branch
defect
Not set
normal

Tracking

(firefox61 fixed)

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: dmajor, Assigned: dmajor)

References

Details

Attachments

(1 file)

https://bugs.llvm.org/show_bug.cgi?id=36886

This will fix Win64 debug xpcshell netwerk/test/unit/test_udpsocket_offline.js
The fix got backed out and will need https://reviews.llvm.org/D44876 in order to re-land.
Relanded in rL328570.
Blocks: 1423667
Just a status note, I'm holding off on landing this until I get the test suite fully green, in case we need further clang fixes.
Perf aside, at this point the only testsuite issue remaining is bug 1448976. It may take a while, and it's only an issue with ThinLTO. So this seems like a good time for a new clang revision.
Attached patch clang328769Splinter Review
Arbitrary trunk revision chosen by:

* Pick an interesting fix (in this case, Sylvestre's 7.0 -> 7 version renaming)
* Scan history for alarming backouts shortly after it (none)
* Run it through try (green)
Assignee: nobody → dmajor
Attachment #8963726 - Flags: review?(core-build-config-reviews)
(For the sake of documenting my process, I'll add that I go through all the major sub-repos when selecting a revision, to make sure I get coordinated changes together. E.g. Sylvestre's fix was r328768+328769.)
Attachment #8963726 - Flags: review?(core-build-config-reviews) → review+
https://hg.mozilla.org/mozilla-central/rev/669bffb66604
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Blocks: 1451479
Version: Version 3 → 3 Branch
You need to log in before you can comment on or make changes to this bug.