1448528 - Missing exit full-screen button for videos

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Audio/Video, defect)

Description

[Winson Wen]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0
Build ID: 20180323221725

Steps to reproduce:

Open a video in Firefox
Press the full-screen button


Actual results:

The exit full-screen button icon is missing. Tapping where it should be still works to exit full-screen.


Expected results:

Icon is present.

Comment 1

[Winson Wen]

Possibly related to Bug 1444489?

Comment 2

[Jan Henning [:JanH]]

Seems likely.

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Thank you for filing the bug. I most have broken my own patch while histedit the changesets ...

This can be fixed by listing fullscreenExitButton.svg in the mobile jar.mn. I will submit a patch soon.

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: Bug 1448528 - Include fullscreenExitButton.svg in mobile package

Review commit: https://reviewboard.mozilla.org/r/230964/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/230964/

Comment 5

[Ken Riley]

FWIW, I reported this bug on 1379389. No one could reproduce it. The latest version of Firefox Android where ALL fullscreen controls were drawn properly in desktop mode was 47. Starting with 48, a control in the upper right (info control?) was improperly drawn and the problem got progressively worse (no exit full screen, no settings icon).

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Ken Riley from comment #5)
> FWIW, I reported this bug on 1379389. No one could reproduce it. The latest
> version of Firefox Android where ALL fullscreen controls were drawn properly
> in desktop mode was 47. Starting with 48, a control in the upper right (info
> control?) was improperly drawn and the problem got progressively worse (no
> exit full screen, no settings icon).

Your bug is unrelated to this one because you are talking about controls implemented by YouTube themselves. We are working on controls offered in Firefox natively here.

Comment 7

[:Gijs (he/him)]

Comment on attachment 8962121 [details]
Bug 1448528 - Include fullscreenExitButton.svg in mobile package

https://reviewboard.mozilla.org/r/230964/#review236584

D'oh. r=me. I wish we had a fix for bug 1422041, which I think might have caught this.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/89a60060413f
Include fullscreenExitButton.svg in mobile package r=Gijs

Comment 9

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/89a60060413f

Comment 10

[Levente Sacal]

Verified as fixed on Nightly 61.0a1 (2018-04-01) using Huawei M3 Lite 10 Tablet (Android 7.0) and Google Pixel XL (Android 8.1.0)