Closed Bug 1448528 Opened 3 years ago Closed 3 years ago

Missing exit full-screen button for videos

Categories

(Firefox for Android Graveyard :: Audio/Video, defect)

Firefox 61
All
Android
defect
Not set
normal

Tracking

(firefox59 unaffected, firefox60 unaffected, firefox61 verified)

VERIFIED FIXED
Firefox 61
Tracking Status
firefox59 --- unaffected
firefox60 --- unaffected
firefox61 --- verified

People

(Reporter: winson.wen1, Assigned: timdream)

References

Details

(Keywords: regression)

Attachments

(1 file)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0
Build ID: 20180323221725

Steps to reproduce:

Open a video in Firefox
Press the full-screen button


Actual results:

The exit full-screen button icon is missing. Tapping where it should be still works to exit full-screen.


Expected results:

Icon is present.
Possibly related to Bug 1444489?
Seems likely.
Status: UNCONFIRMED → NEW
Component: General → Audio/Video
Ever confirmed: true
Flags: needinfo?(timdream)
Keywords: regression
OS: Unspecified → Android
Hardware: Unspecified → All
Thank you for filing the bug. I most have broken my own patch while histedit the changesets ...

This can be fixed by listing fullscreenExitButton.svg in the mobile jar.mn. I will submit a patch soon.
Assignee: nobody → timdream
Blocks: 1444489
Status: NEW → ASSIGNED
Flags: needinfo?(timdream)
FWIW, I reported this bug on 1379389. No one could reproduce it. The latest version of Firefox Android where ALL fullscreen controls were drawn properly in desktop mode was 47. Starting with 48, a control in the upper right (info control?) was improperly drawn and the problem got progressively worse (no exit full screen, no settings icon).
(In reply to Ken Riley from comment #5)
> FWIW, I reported this bug on 1379389. No one could reproduce it. The latest
> version of Firefox Android where ALL fullscreen controls were drawn properly
> in desktop mode was 47. Starting with 48, a control in the upper right (info
> control?) was improperly drawn and the problem got progressively worse (no
> exit full screen, no settings icon).

Your bug is unrelated to this one because you are talking about controls implemented by YouTube themselves. We are working on controls offered in Firefox natively here.
Comment on attachment 8962121 [details]
Bug 1448528 - Include fullscreenExitButton.svg in mobile package

https://reviewboard.mozilla.org/r/230964/#review236584

D'oh. r=me. I wish we had a fix for bug 1422041, which I think might have caught this.
Attachment #8962121 - Flags: review?(gijskruitbosch+bugs) → review+
Pushed by timdream@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/89a60060413f
Include fullscreenExitButton.svg in mobile package r=Gijs
https://hg.mozilla.org/mozilla-central/rev/89a60060413f
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Verified as fixed on Nightly 61.0a1 (2018-04-01) using Huawei M3 Lite 10 Tablet (Android 7.0) and Google Pixel XL (Android 8.1.0)
Status: RESOLVED → VERIFIED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.