bustage at xpcom/threads/SchedulerGroup.cpp:67:16: error: 'class mozilla::SchedulerGroup::Runnable' has no member named 'GetName' when Gecko 61 merges to Beta on 2018-04-26

VERIFIED FIXED in Firefox 61

Status

()

defect
P1
blocker
VERIFIED FIXED
Last year
Last year

People

(Reporter: aryx, Assigned: froydnj)

Tracking

unspecified
mozilla61
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr52 unaffected, firefox59 unaffected, firefox60 unaffected, firefox61blocking verified)

Details

Attachments

(1 attachment)

Regression from bug 1447744.

central-as-beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7e9bf98b32fca04328de9b203435d2147c5798a9&selectedJob=170035712

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=170035689&repo=try

[task 2018-03-24T10:34:04.899Z] 10:34:04     INFO -  In file included from /builds/worker/workspace/build/src/obj-firefox/xpcom/threads/Unified_cpp_xpcom_threads1.cpp:2:0:
[task 2018-03-24T10:34:04.900Z] 10:34:04     INFO -  /builds/worker/workspace/build/src/xpcom/threads/SchedulerGroup.cpp: In constructor '{anonymous}::AutoCollectVsyncTelemetry::AutoCollectVsyncTelemetry(mozilla::SchedulerGroup::Runnable*)':
[task 2018-03-24T10:34:04.900Z] 10:34:04     INFO -  /builds/worker/workspace/build/src/xpcom/threads/SchedulerGroup.cpp:67:16: error: 'class mozilla::SchedulerGroup::Runnable' has no member named 'GetName'
[task 2018-03-24T10:34:04.900Z] 10:34:04     INFO -       aRunnable->GetName(mKey);
[task 2018-03-24T10:34:04.901Z] 10:34:04     INFO -                  ^~~~~~~

Once fixed, Linux and Windows opt will still be busted in beta simulations (bug 1448070).
Flags: needinfo?(nfroyd)
This only affects early beta.
Assignee

Comment 2

Last year
We had this for Quantum DOM, but that effort is stalled/dead, so we
should just remove the code and associated Telemetry histograms.
Attachment #8962482 - Flags: review?(afarre)
Assignee

Comment 3

Last year
Sigh, I wondered if that code was going to bust things. :(
Assignee: nobody → nfroyd
Flags: needinfo?(nfroyd)
This blocks the next uplift, so bumping accordingly.
Priority: -- → P1
Attachment #8962482 - Flags: review?(afarre) → review+

Comment 6

Last year
bugherder
https://hg.mozilla.org/mozilla-central/rev/09670a66e09a
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.