1448544 - bustage at xpcom/threads/SchedulerGroup.cpp:67:16: error: 'class mozilla::SchedulerGroup::Runnable' has no member named 'GetName' when Gecko 61 merges to Beta on 2018-04-26

Status: VERIFIED FIXED

(Core :: XPCOM, defect, P1)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Regression from bug 1447744.

central-as-beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7e9bf98b32fca04328de9b203435d2147c5798a9&selectedJob=170035712

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=170035689&repo=try

[task 2018-03-24T10:34:04.899Z] 10:34:04     INFO -  In file included from /builds/worker/workspace/build/src/obj-firefox/xpcom/threads/Unified_cpp_xpcom_threads1.cpp:2:0:
[task 2018-03-24T10:34:04.900Z] 10:34:04     INFO -  /builds/worker/workspace/build/src/xpcom/threads/SchedulerGroup.cpp: In constructor '{anonymous}::AutoCollectVsyncTelemetry::AutoCollectVsyncTelemetry(mozilla::SchedulerGroup::Runnable*)':
[task 2018-03-24T10:34:04.900Z] 10:34:04     INFO -  /builds/worker/workspace/build/src/xpcom/threads/SchedulerGroup.cpp:67:16: error: 'class mozilla::SchedulerGroup::Runnable' has no member named 'GetName'
[task 2018-03-24T10:34:04.900Z] 10:34:04     INFO -       aRunnable->GetName(mKey);
[task 2018-03-24T10:34:04.901Z] 10:34:04     INFO -                  ^~~~~~~

Once fixed, Linux and Windows opt will still be busted in beta simulations (bug 1448070).

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

This only affects early beta.

Comment 2

[Nathan Froyd [:froydnj]]

Attachment: remove AutoVsyncTelemetry

We had this for Quantum DOM, but that effort is stalled/dead, so we
should just remove the code and associated Telemetry histograms.

Comment 3

[Nathan Froyd [:froydnj]]

Sigh, I wondered if that code was going to bust things. :(

Comment 4

[Ryan VanderMeulen [:RyanVM]]

This blocks the next uplift, so bumping accordingly.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/09670a66e09a
remove AutoVsyncTelemetry; r=farre

Comment 6

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/09670a66e09a

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Thank you. Verified fixed in the latest central-as-beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7193c554d26cbfa22f3a124527a31ee898fed64a&group_state=expanded&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable