Closed Bug 1448574 Opened 2 years ago Closed 2 years ago

nsXULWindow should format integers directly into UTF-16 instead of using an intermediate char buffer

Categories

(Core :: XUL, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: hsivonen, Assigned: hsivonen)

References

Details

Attachments

(1 file)

We should simplify code like this:
      SprintfLiteral(sizeBuf, "%d", NSToIntRound(rect.X() / posScale.scale));
      CopyASCIItoUTF16(sizeBuf, sizeString);
Attachment #8962071 - Flags: review?(bzbarsky)
Comment on attachment 8962071 [details]
Bug 1448574 - Format integers directly into UTF-16 in nsXULWindow.

https://reviewboard.mozilla.org/r/230904/#review237386

r=me
Attachment #8962071 - Flags: review?(bzbarsky) → review+
Pushed by hsivonen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/73958e9bfd07
Format integers directly into UTF-16 in nsXULWindow. r=bz
Sorry. Relanded with copypaste error fixed.
Flags: needinfo?(hsivonen)
Pushed by hsivonen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8bd11028a413
Format integers directly into UTF-16 in nsXULWindow. r=bz
https://hg.mozilla.org/mozilla-central/rev/8bd11028a413
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.