Closed Bug 1448583 Opened 6 years ago Closed 6 years ago

Back/forward button state not updated on subframe navigation

Categories

(GeckoView :: General, defect)

Product:
GeckoView
Component:
General
Version:
61 Branch
Platform:
All
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox59 unaffected, firefox60 unaffected, firefox61 verified)

Status:
VERIFIED FIXED
Milestone:
mozilla61
Tracking Flags:
Tracking Status
firefox59 --- unaffected
firefox60 --- unaffected
firefox61 --- verified

People

(Reporter: JanH, Assigned: droeh)

References

Details

Attachments

(1 file)

Send onCanGoBack/Forward for non-top-level location changes
2.33 KB, patch
snorp
: review+
Details | Diff | Splinter Review 
Repeat performance of bug 1269210, this time for GeckoView.
Flags: needinfo?(droeh)
Good catch, thanks Jan!
Assignee: nobody → droeh
Status: NEW → ASSIGNED
Flags: needinfo?(droeh)
Attachment #8962734 - Flags: review?(snorp)
Attachment #8962734 - Flags: review?(snorp) → review+
Pushed by droeh@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c82e44b964b8
Call onCanGoBack/Forward for non-top-level location changes. r=snorp
https://hg.mozilla.org/mozilla-central/rev/c82e44b964b8
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox61: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Verified as fixed on Nightly 61.0a1 (2018-04-01) using the steps from bug 1269210 (https://bugzilla.mozilla.org/show_bug.cgi?id=1269210) on Huawei M3 Lite 10 Tablet (Android 7.0) and Google Pixel XL (Android 8.1.0)
Status: RESOLVED → VERIFIED
status-firefox61: fixed → verified
Product: Firefox for Android → GeckoView
Version: Firefox 61 → 61 Branch
Keywords: regression
Target Milestone: Firefox 61 → mozilla61
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: