1448586 - Avoid useless use of NS_LITERAL_CSTRING when prefixing query string with question mark

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Henri Sivonen (:hsivonen)]

Let's not do this:
CopyUTF8toUTF16(NS_LITERAL_CSTRING("?") + search, _search);

Comment 1

[Henri Sivonen (:hsivonen)]

Attachment: Bug 1448586 - Avoid useless use of NS_LITERAL_CSTRING when prefixing query string with question mark. .

Review commit: https://reviewboard.mozilla.org/r/230928/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/230928/

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8962081 [details]
Bug 1448586 - Avoid useless use of NS_LITERAL_CSTRING when prefixing query string with question mark. .

https://reviewboard.mozilla.org/r/230928/#review236438

::: dom/url/URLMainThread.cpp:430
(Diff revision 1)
>    nsAutoCString search;
>    nsresult rv;
>  
>    rv = mURI->GetQuery(search);
>    if (NS_SUCCEEDED(rv) && !search.IsEmpty()) {
> -    CopyUTF8toUTF16(NS_LITERAL_CSTRING("?") + search, aSearch);
> +    aSearch.Assign((char16_t)'?');

Isn't the normal style to use u prefix before the literal, not c-style casting.
Same also elsewhere.

Comment 3

[Henri Sivonen (:hsivonen)]

Comment on attachment 8962081 [details]
Bug 1448586 - Avoid useless use of NS_LITERAL_CSTRING when prefixing query string with question mark. .

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/230928/diff/1-2/

Comment 4

[Henri Sivonen (:hsivonen)]

Comment on attachment 8962081 [details]
Bug 1448586 - Avoid useless use of NS_LITERAL_CSTRING when prefixing query string with question mark. .

https://reviewboard.mozilla.org/r/230928/#review236438

> Isn't the normal style to use u prefix before the literal, not c-style casting.
> Same also elsewhere.

Fixed. Thanks.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/04f9d83550c2
Avoid useless use of NS_LITERAL_CSTRING when prefixing query string with question mark. r=smaug.

Comment 6

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/04f9d83550c2