Closed Bug 1448600 Opened 2 years ago Closed 2 years ago

Remove the customizeToolbar overlay

Categories

(Thunderbird :: Toolbars and Tabs, enhancement)

Product:
Thunderbird
Component:
Toolbars and Tabs
Type:
enhancement
Priority:
Not set

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 61.0

People

(Reporter: Paenglab, Assigned: Paenglab)

References

Details

Attachments

(1 file, 1 obsolete file)

customizeToolbarOverlay.patch
14.56 KB, patch
jorgk
: review+
Details | Diff | Splinter Review 
customizeToolbarOverlay.xul overlays the customizeToolbar.xul. With moving customizeToolbar.xul to c-c we need this overlay no more.
Attached patch customizeToolbarOverlay.patch (obsolete) — — Splinter Review 
The downloadsOverlay is also no more needed as chrome://mozapps/content/downloads/downloads.xul no more exists.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8962094 - Flags: review?(jorgk)
Comment on attachment 8962094 [details] [diff] [review]
customizeToolbarOverlay.patch

Review of attachment 8962094 [details] [diff] [review]:
-----------------------------------------------------------------

Looks OK with one question below.

::: mail/base/content/customizeToolbarOverlay.xul
@@ -18,5 @@
> -  <menulist id="modelist"
> -            oncommand="overlayUpdateToolbarMode(this.value, 'mail-toolbox');"/>
> -
> -  <window id="CustomizeToolbarWindow"
> -          windowtype="mailnews:customizeToolbar"

Did you miss this?
(In reply to Jorg K (GMT+1) from comment #2)
> Comment on attachment 8962094 [details] [diff] [review]
> customizeToolbarOverlay.patch
> 
> Review of attachment 8962094 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Looks OK with one question below.
> 
> ::: mail/base/content/customizeToolbarOverlay.xul
> @@ -18,5 @@
> > -  <menulist id="modelist"
> > -            oncommand="overlayUpdateToolbarMode(this.value, 'mail-toolbox');"/>
> > -
> > -  <window id="CustomizeToolbarWindow"
> > -          windowtype="mailnews:customizeToolbar"
> 
> Did you miss this?

It worked without it. Added it now.
Attachment #8962094 - Attachment is obsolete: true
Attachment #8962094 - Flags: review?(jorgk)
Attachment #8962095 - Flags: review?(jorgk)
Comment on attachment 8962095 [details] [diff] [review]
customizeToolbarOverlay.patch

Works for me, thanks.
Attachment #8962095 - Flags: review?(jorgk) → review+
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/95393731492e
Remove the customizeToolbar overlay. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 61.0
Blocks: 1444468
You need to log in before you can comment on or make changes to this bug.