Closed
Bug 1448600
Opened 7 years ago
Closed 7 years ago
Remove the customizeToolbar overlay
Categories
(Thunderbird :: Toolbars and Tabs, enhancement)
Thunderbird
Toolbars and Tabs
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 61.0
People
(Reporter: Paenglab, Assigned: Paenglab)
References
Details
Attachments
(1 file, 1 obsolete file)
|
14.56 KB,
patch
|
jorgk-bmo
:
review+
|
Details | Diff | Splinter Review |
customizeToolbarOverlay.xul overlays the customizeToolbar.xul. With moving customizeToolbar.xul to c-c we need this overlay no more.
|
Assignee | |
Comment 1•7 years ago
|
||
The downloadsOverlay is also no more needed as chrome://mozapps/content/downloads/downloads.xul no more exists.
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8962094 [details] [diff] [review]
customizeToolbarOverlay.patch
Review of attachment 8962094 [details] [diff] [review]:
-----------------------------------------------------------------
Looks OK with one question below.
::: mail/base/content/customizeToolbarOverlay.xul
@@ -18,5 @@
> - <menulist id="modelist"
> - oncommand="overlayUpdateToolbarMode(this.value, 'mail-toolbox');"/>
> -
> - <window id="CustomizeToolbarWindow"
> - windowtype="mailnews:customizeToolbar"
Did you miss this?
|
|
Assignee | |
Comment 3•7 years ago
|
||
(In reply to Jorg K (GMT+1) from comment #2)
> Comment on attachment 8962094 [details] [diff] [review]
> customizeToolbarOverlay.patch
>
> Review of attachment 8962094 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> Looks OK with one question below.
>
> ::: mail/base/content/customizeToolbarOverlay.xul
> @@ -18,5 @@
> > - <menulist id="modelist"
> > - oncommand="overlayUpdateToolbarMode(this.value, 'mail-toolbox');"/>
> > -
> > - <window id="CustomizeToolbarWindow"
> > - windowtype="mailnews:customizeToolbar"
>
> Did you miss this?
It worked without it. Added it now.
Attachment #8962094 -
Attachment is obsolete: true
Attachment #8962094 -
Flags: review?(jorgk)
Attachment #8962095 -
Flags: review?(jorgk)
|
|
||
Comment 4•7 years ago
|
||
Comment on attachment 8962095 [details] [diff] [review]
customizeToolbarOverlay.patch
Works for me, thanks.
Attachment #8962095 -
Flags: review?(jorgk) → review+
|
|
Assignee | |
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/95393731492e
Remove the customizeToolbar overlay. r=jorgk
|
|
||
Updated•7 years ago
|
Target Milestone: --- → Thunderbird 61.0
You need to log in
before you can comment on or make changes to this bug.
Description
•