1448629 - Port bug 1440573 and bug 1432779 to TB

Status: RESOLVED FIXED

(Thunderbird :: General, enhancement)

Description

[Richard Marti (:Paenglab)]

Two about:support bugs to port to TB:

Bug 1440573: Policy: Disable safe mode
Bug 1432779: Remove the concept of preferred layout

Comment 1

[Richard Marti (:Paenglab)]

Attachment: policyDisable.patch

Simple port of
https://hg.mozilla.org/mozilla-central/rev/cd250ee025a5#l8.12
and
https://hg.mozilla.org/mozilla-central/rev/4e8af01f19c29b43c1f0606d1fac0d262c777b40#l10.12

Comment 2

[:aceman]

Comment on attachment 8962129 [details] [diff] [review]
policyDisable.patch

Review of attachment 8962129 [details] [diff] [review]:
-----------------------------------------------------------------

Don't we want also the browser/base/content/utilityOverlay.js change to hide the menuitem?

We should probably think if we want the policy engine in TB. Surely enterprises would like it.

::: mail/components/about-support/content/aboutSupport.js
@@ +1232,5 @@
>    if (ResetProfile.resetSupported()) {
>      $("reset-box").style.display = "block";
>      $("action-box").style.display = "block";
>    }
> +  if (!Services.appinfo.inSafeMode && AppConstants.platform !== "android") {

The android check wasn't int he 2 m-c patches. Are we missing some other change yet?

Comment 4

[Richard Marti (:Paenglab)]

(In reply to :aceman from comment #2)
> Comment on attachment 8962129 [details] [diff] [review]
> policyDisable.patch
> 
> Review of attachment 8962129 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Don't we want also the browser/base/content/utilityOverlay.js change to hide
> the menuitem?

We have no policies support.

Comment 5

[Jorg K (CEST = GMT+2)]

(In reply to :aceman from comment #2)
> The android check wasn't int he 2 m-c patches. Are we missing some other
> change yet?
That's from bug 1366575 from June 2017 here:
https://hg.mozilla.org/mozilla-central/rev/7764549d5ddc

function setupEventListeners() is different now, but it was different before. Any need for more porting here?

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/89435f04afee
Port bug 1440573 and bug 1432779 to TB (adjustments to about:support). r=aceman

Comment 7

[Richard Marti (:Paenglab)]

I must have missed it. I'll try to do this in a new bug.

Comment 8

[:aceman]

(In reply to Richard Marti (:Paenglab) from comment #4)
> We have no policies support.

Yes, we may not have any now, but the council should decide if we don't want some. It would be useful for enterprises.

Comment 9

[Richard Marti (:Paenglab)]

Policy support is in browser. If TB wants it too, we have to clone it. They don't plan to move it to toolkit.