1448654 - clang.exe: warning: unknown argument ignored in clang-cl: '-mstackrealign' [-Wunknown-argument]

Status: RESOLVED DUPLICATE of bug 1448189

(Core :: Graphics, defect)

Description

[Jan Beich]

While Clang on Windows x86 uses 4-byte stack alignment clang-cl doesn't support -mstack*. Let's ignore those. Affects only static-analysis-win32-st-an jobs on TreeHerder.

11:19:54     INFO -  mozmake.EXE[4]: Entering directory 'z:/build/build/src/obj-firefox/gfx/skia'
11:19:54     INFO -  z:/build/build/src/sccache2/sccache.exe z:/build/build/src/clang/bin/clang.exe --driver-mode=cl -FoSkJumper.obj -c -Iz:/build/build/src/obj-firefox/dist/stl_wrappers -DNDEBUG=1 -DTRIMMED=1 -DUNICODE -D_UNICODE -DSKIA_IMPLEMENTATION=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -Iz:/build/build/src/gfx/skia -Iz:/build/build/src/obj-firefox/gfx/skia -Iz:/build/build/src/gfx/skia/skia/include/c -Iz:/build/build/src/gfx/skia/skia/include/codec -Iz:/build/build/src/gfx/skia/skia/include/config -Iz:/build/build/src/gfx/skia/skia/include/core -Iz:/build/build/src/gfx/skia/skia/include/effects -Iz:/build/build/src/gfx/skia/skia/include/encode -Iz:/build/build/src/gfx/skia/skia/include/gpu -Iz:/build/build/src/gfx/skia/skia/include/pathops -Iz:/build/build/src/gfx/skia/skia/include/ports -Iz:/build/build/src/gfx/skia/skia/include/private -Iz:/build/build/src/gfx/skia/skia/include/utils -Iz:/build/build/src/gfx/skia/skia/include/utils/mac -Iz:/build/build/src/gfx/skia/skia/include/views -Iz:/build/build/src/gfx/skia/skia/src/core -Iz:/build/build/src/gfx/skia/skia/src/gpu -Iz:/build/build/src/gfx/skia/skia/src/gpu/effects -Iz:/build/build/src/gfx/skia/skia/src/gpu/gl -Iz:/build/build/src/gfx/skia/skia/src/gpu/glsl -Iz:/build/build/src/gfx/skia/skia/src/image -Iz:/build/build/src/gfx/skia/skia/src/lazy -Iz:/build/build/src/gfx/skia/skia/src/opts -Iz:/build/build/src/gfx/skia/skia/src/sfnt -Iz:/build/build/src/gfx/skia/skia/src/shaders -Iz:/build/build/src/gfx/skia/skia/src/sksl -Iz:/build/build/src/gfx/skia/skia/src/utils -Iz:/build/build/src/gfx/skia/skia/src/utils/mac -Iz:/build/build/src/gfx/skia/skia/src/utils/win -Iz:/build/build/src/obj-firefox/dist/include -Iz:/build/build/src/obj-firefox/dist/include/nspr -Iz:/build/build/src/obj-firefox/dist/include/nss -MD -FI z:/build/build/src/obj-firefox/mozilla-config.h -DMOZILLA_CLIENT -Qunused-arguments -Qunused-arguments -TP -nologo -w15038 -wd5026 -wd5027 -Zc:sizedDealloc- -wd4091 -wd4577 -D_HAS_EXCEPTIONS=0 -W3 -Gy -Zc:inline -arch:SSE2 -Gw -wd4251 -wd4244 -wd4267 -wd4800 -wd4595 -Wno-inline-new-delete -Wno-invalid-offsetof -Wno-microsoft-enum-value -Wno-microsoft-include -Wno-unknown-pragmas -Wno-ignored-pragmas -Wno-deprecated-declarations -Wno-invalid-noreturn -Wno-inconsistent-missing-override -Wno-implicit-exception-spec-mismatch -Wno-unused-local-typedef -Wno-ignored-attributes -we4553 -D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING -GR- -Z7 -Xclang -load -Xclang z:/build/build/src/obj-firefox/build/clang-plugin/clang-plugin.dll -Xclang -add-plugin -Xclang moz-check -O1 -Oi -Oy- -Wno-deprecated-declarations -Wno-overloaded-virtual -Wno-shadow -Wno-sign-compare -Wno-unreachable-code -Wno-unused-function -Wno-implicit-fallthrough -Wno-inconsistent-missing-override -Wno-macro-redefined -Wno-unused-private-field  -Xclang -MP -Xclang -MG -Xclang -dependency-file -Xclang .deps/SkJumper.obj.pp -Xclang -MT -Xclang SkJumper.obj   -O2 -mstack-alignment=16 -mstackrealign z:/build/build/src/gfx/skia/skia/src/jumper/SkJumper.cpp
11:19:54     INFO -  clang.exe: warning: unknown argument ignored in clang-cl: '-mstack-alignment=16' [-Wunknown-argument]
11:19:54     INFO -  clang.exe: warning: unknown argument ignored in clang-cl: '-mstackrealign' [-Wunknown-argument]
11:19:54     INFO -  mozmake.EXE[4]: Leaving directory 'z:/build/build/src/obj-firefox/gfx/skia'

https://taskcluster-artifacts.net/TdtgQ_WcSVqnZOqKO7x5sQ/0/public/logs/live_backing.log

Comment 1

[Jan Beich]

Attachment: Bug 1448654 - Don't use -mstackrealign with clang-cl, it's unused.

clang.exe: warning: unknown argument ignored in clang-cl: '-mstack-alignment=16' [-Wunknown-argument]
clang.exe: warning: unknown argument ignored in clang-cl: '-mstackrealign' [-Wunknown-argument]

Review commit: https://reviewboard.mozilla.org/r/230996/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/230996/

Comment 2

[Jan Beich]

-Wunknown-argument not triggering an error even with --enable-warnings-as-errors was unexpected. Anyway, I don't have a Windows VM/machine around to investigate.

Comment 3

[Lee Salzman [:lsalzman]]

Pushed this as a follow-up to bug 1448189 to keep things easier for a possible uplift. The Skia assembly code actually already aligns the stack to 16 bytes on Windows, so we didn't actually need this for clang-cl anyway. Therefor, it is safe to do this for only clang.

Comment 5

[Lee Salzman [:lsalzman]]

Comment on attachment 8962144 [details]
Bug 1448654 - Don't use -mstackrealign with clang-cl, it's unused.

https://reviewboard.mozilla.org/r/230996/#review237126