Fix up comments referring to "style context" after the rename of nsStyleContext

RESOLVED FIXED in Firefox 61

Status

()

enhancement
RESOLVED FIXED
Last year
Last year

People

(Reporter: jwatt, Assigned: jwatt)

Tracking

unspecified
mozilla61
Points:
---

Firefox Tracking Flags

(firefox61 fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

Assignee

Description

Last year
No description provided.
Assignee

Comment 1

Last year
Posted patch patch (obsolete) — Splinter Review
Attachment #8962209 - Flags: review?(emilio)
Assignee

Comment 2

Last year
Posted patch patch (obsolete) — Splinter Review
Attachment #8962209 - Attachment is obsolete: true
Attachment #8962209 - Flags: review?(emilio)
Attachment #8962210 - Flags: review?(emilio)
Assignee

Comment 3

Last year
Posted patch patchSplinter Review
Sorry for the noise.
Attachment #8962210 - Attachment is obsolete: true
Attachment #8962210 - Flags: review?(emilio)
Attachment #8962211 - Flags: review?(emilio)
Comment on attachment 8962211 [details] [diff] [review]
patch

Review of attachment 8962211 [details] [diff] [review]:
-----------------------------------------------------------------

Looks like for most of these, just "style" instead of "ComputedStyle" would've been enough and maybe clearer, but I'm fine with landing this, thanks!

Double-check that there's no GTK widget code changed (GTK does have StyleContext).

::: layout/base/PresShell.cpp
@@ +4269,5 @@
>  
>      // Now those constructors or events might have posted restyle
>      // events.  At the same time, we still need up-to-date style data.
>      // In particular, reflow depends on style being completely up to
> +    // date.  If it's not, then ComputedStyle reparenting, which can

Just style reparenting please.

::: layout/base/nsChangeHint.h
@@ +165,5 @@
>  
>    /**
>     * A hint reflecting that style data changed with no change handling
>     * behavior.  We need to return this, rather than nsChangeHint(0),
> +   * so that certain optimizations that manipulate the ComputedStyle tree are

Just style tree.

::: layout/style/test/test_align_justify_computed_values.html
@@ +132,5 @@
>   */
>  function main() {
>    // Test the root node
>    // ==================
> +  // (It's special because it has no parent ComputedStyle.)

For some of these, I think just "style" suffices here. But it's not a big deal

::: toolkit/components/viewsource/content/viewSource-content.js
@@ +767,5 @@
>      this.updateContextMenu();
>    },
>  
>    /**
> +   * Update state of checkbox-ComputedStyle menu items.

This one doesn't seem like it should be changed.
Attachment #8962211 - Flags: review?(emilio) → review+

Comment 5

Last year
Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cc4577ab2771
Fix up comments referring to 'style context' after the rename of nsStyleContext. r=emilio

Comment 6

Last year
bugherder
https://hg.mozilla.org/mozilla-central/rev/cc4577ab2771
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.