1448734 - Stop exposing Components in content XBL sopes

Status: RESOLVED FIXED

(Core :: XBL, enhancement)

Description

[Boris Zbarsky [:bzbarsky]]

None of the bindings we apply to content normally use Components.  We should just stop exposing it in content XBL scopes, on the way to making Components only available to system-principal stuff.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Stop exposing Components in content XBL scopes

Kris, let me know if you would rather we just wait until Bobby gets back to get this reviewed.  But I don't think he'd object.  ;)

Comment 2

[Kris Maglione [:kmag]]

Comment on attachment 8962228 [details] [diff] [review]
Stop exposing Components in content XBL scopes

Review of attachment 8962228 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/xpconnect/tests/chrome/test_bug795275.xul
@@ +65,5 @@
>      getWin('frame2').touchInterfaces();
>      getWin('frame4').touchComponents();
>      getWin('frame4').touchInterfaces();
> +    // This should warn twice (actually throw exceptions, because Components
> +    // won't be defined).

I don't think this is right. It definitely emits the warning, which means we're accessing the content window's Components getter. Which it is defined. (Also, it doesn't seem to throw.)

Comment 3

[Boris Zbarsky [:bzbarsky]]

> I don't think this is right.

Right you are.  I'll fix the comments.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2f9c9c64510c
Stop exposing Components in content XBL scopes.  r=kmag

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/2f9c9c64510c