Closed Bug 1448746 Opened 3 years ago Closed 3 years ago

Capitalization Fixes for MinGW x64

Categories

(Toolkit :: Crash Reporting, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox-esr60 --- fixed
firefox61 --- fixed

People

(Reporter: tjr, Assigned: tjr)

References

Details

Attachments

(2 files)

Comment on attachment 8962239 [details]
Bug 1448746 Capitalization fixes for MinGW x64 build in the crash reporter

https://reviewboard.mozilla.org/r/231082/#review236522

Looking good.
Attachment #8962239 - Flags: review?(gsvelto) → review+
Pushed by ncsoregi@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/412b3c06c06d
Capitalization fixes for MinGW x64 build in the crash reporter r=gsvelto
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/412b3c06c06d
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Attached patch esr60.patchSplinter Review
[Approval Request Comment]

This is one of several MinGW Build patches I'd like to land in esr60 for Tor. It will prevent them from carrying their own patches for the lifetime of esr60 and will enable us to keep the MinGW build functioning and know if/when/how it was broken by new commits into esr60.

This commit does affect non-MinGW builds; but it's only a capitalization change it's low-risk.
Attachment #8976266 - Flags: approval-mozilla-esr60?
Comment on attachment 8976266 [details] [diff] [review]
esr60.patch

mingw build fix, approved for 60.1esr
Attachment #8976266 - Flags: approval-mozilla-esr60? → approval-mozilla-esr60+
You need to log in before you can comment on or make changes to this bug.