1448746 - Capitalization Fixes for MinGW x64

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, enhancement)

Comment 1

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Attachment: Bug 1448746 Capitalization fixes for MinGW x64 build in the crash reporter

Review commit: https://reviewboard.mozilla.org/r/231082/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/231082/

Comment 2

[Gabriele Svelto [:gsvelto] (PTO)]

Comment on attachment 8962239 [details]
Bug 1448746 Capitalization fixes for MinGW x64 build in the crash reporter

https://reviewboard.mozilla.org/r/231082/#review236522

Looking good.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/412b3c06c06d
Capitalization fixes for MinGW x64 build in the crash reporter r=gsvelto

Comment 4

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/412b3c06c06d

Comment 5

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Attachment: esr60.patch

[Approval Request Comment]

This is one of several MinGW Build patches I'd like to land in esr60 for Tor. It will prevent them from carrying their own patches for the lifetime of esr60 and will enable us to keep the MinGW build functioning and know if/when/how it was broken by new commits into esr60.

This commit does affect non-MinGW builds; but it's only a capitalization change it's low-risk.

Comment 6

[Julien Cristau [:jcristau]]

Comment on attachment 8976266 [details] [diff] [review]
esr60.patch

mingw build fix, approved for 60.1esr

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr60/rev/0e11f150a482