1448759 - Remove nsCSSPropList.h and nsCSSPropAliasList.h

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Xidorn Quan [:xidorn] UTC+10]

That list contains lots of bits which should only be useful for the old style system. We should investigate what dependencies left on them.

Comment 1

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1448759 part 1 - Make KTableEntry an independent type.

Review commit: https://reviewboard.mozilla.org/r/240612/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/240612/

Comment 2

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1448759 part 2 - Have nsStyleUtil::AppendBitmaskCSSValue take a keyword table directly.

Review commit: https://reviewboard.mozilla.org/r/240614/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/240614/

Comment 3

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1448759 part 3 - Remove kKeywordTableTable and LookupPropertyValue.

Review commit: https://reviewboard.mozilla.org/r/240616/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/240616/

Comment 4

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1448759 part 4 - Switch gAllSubpropTable to use generated ServoCSSPropList.h.

Review commit: https://reviewboard.mozilla.org/r/240618/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/240618/

Comment 5

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1448759 part 5 - Remove nsCSSPropList.h and nsCSSPropAliasList.h.

Review commit: https://reviewboard.mozilla.org/r/240620/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/240620/

Comment 6

[Cameron McCormack (:heycam)]

Comment on attachment 8971869 [details]
Bug 1448759 part 1 - Make KTableEntry an independent type.

https://reviewboard.mozilla.org/r/240612/#review246292

::: layout/style/nsCSSProps.h:34
(Diff revision 1)
> -  typedef mozilla::CSSEnabledState EnabledState;
> -  typedef mozilla::CSSPropFlags Flags;
> -
> -  struct KTableEntry
> -  {
> +{
> -    // KTableEntry objects can be initialized either with an int16_t value
> +  // KTableEntry objects can be initialized either with an int16_t value

Update the name here.

Comment 7

[Cameron McCormack (:heycam)]

Comment on attachment 8971870 [details]
Bug 1448759 part 2 - Have nsStyleUtil::AppendBitmaskCSSValue take a keyword table directly.

https://reviewboard.mozilla.org/r/240614/#review246294

Comment 8

[Cameron McCormack (:heycam)]

Comment on attachment 8971871 [details]
Bug 1448759 part 3 - Remove kKeywordTableTable and LookupPropertyValue.

https://reviewboard.mozilla.org/r/240616/#review246296

Comment 9

[Cameron McCormack (:heycam)]

Comment on attachment 8971872 [details]
Bug 1448759 part 4 - Switch gAllSubpropTable to use generated ServoCSSPropList.h.

https://reviewboard.mozilla.org/r/240618/#review246298

::: layout/style/nsCSSProps.cpp:2206
(Diff revision 1)
>  #undef CSS_PROP_SHORTHAND
>  #undef CSS_PROP_LONGHAND
>  };
>  
>  static const nsCSSPropertyID gAllSubpropTable[] = {
>  #define CSS_PROP_LIST_ONLY_COMPONENTS_OF_ALL_SHORTHAND

This can be removed.

Comment 10

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8971872 [details]
Bug 1448759 part 4 - Switch gAllSubpropTable to use generated ServoCSSPropList.h.

https://reviewboard.mozilla.org/r/240618/#review246298

> This can be removed.

How can this be removed? The whole patch is there just because I find this line cannot be removed...

Comment 11

[Cameron McCormack (:heycam)]

Comment on attachment 8971873 [details]
Bug 1448759 part 5 - Remove nsCSSPropList.h and nsCSSPropAliasList.h.

https://reviewboard.mozilla.org/r/240620/#review246302

Hooray!

Comment 12

[Cameron McCormack (:heycam)]

Comment on attachment 8971872 [details]
Bug 1448759 part 4 - Switch gAllSubpropTable to use generated ServoCSSPropList.h.

https://reviewboard.mozilla.org/r/240618/#review246306

Comment 13

[Cameron McCormack (:heycam)]

Comment on attachment 8971872 [details]
Bug 1448759 part 4 - Switch gAllSubpropTable to use generated ServoCSSPropList.h.

https://reviewboard.mozilla.org/r/240618/#review246298

> How can this be removed? The whole patch is there just because I find this line cannot be removed...

For some reason I skipped over the GenerateServoCSSPropList.py change so I thought we no longer had any use of this macro in ServoCSSPropList.h.  Please ignore!

Comment 14

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8971869 [details]
Bug 1448759 part 1 - Make KTableEntry an independent type.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/240612/diff/1-2/

Comment 15

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8971870 [details]
Bug 1448759 part 2 - Have nsStyleUtil::AppendBitmaskCSSValue take a keyword table directly.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/240614/diff/1-2/

Comment 16

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8971871 [details]
Bug 1448759 part 3 - Remove kKeywordTableTable and LookupPropertyValue.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/240616/diff/1-2/

Comment 17

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8971872 [details]
Bug 1448759 part 4 - Switch gAllSubpropTable to use generated ServoCSSPropList.h.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/240618/diff/1-2/

Comment 18

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8971873 [details]
Bug 1448759 part 5 - Remove nsCSSPropList.h and nsCSSPropAliasList.h.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/240620/diff/1-2/

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f57682050e8e
part 1 - Make KTableEntry an independent type. r=heycam
https://hg.mozilla.org/integration/autoland/rev/3d80ff8515b6
part 2 - Have nsStyleUtil::AppendBitmaskCSSValue take a keyword table directly. r=heycam
https://hg.mozilla.org/integration/autoland/rev/0c1f6fcbcb39
part 3 - Remove kKeywordTableTable and LookupPropertyValue. r=heycam
https://hg.mozilla.org/integration/autoland/rev/7ec44505efeb
part 4 - Switch gAllSubpropTable to use generated ServoCSSPropList.h. r=heycam
https://hg.mozilla.org/integration/autoland/rev/2784dccf11ec
part 5 - Remove nsCSSPropList.h and nsCSSPropAliasList.h. r=heycam

Comment 20

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/f57682050e8e
https://hg.mozilla.org/mozilla-central/rev/3d80ff8515b6
https://hg.mozilla.org/mozilla-central/rev/0c1f6fcbcb39
https://hg.mozilla.org/mozilla-central/rev/7ec44505efeb
https://hg.mozilla.org/mozilla-central/rev/2784dccf11ec