Closed
Bug 1448759
Opened 5 years ago
Closed 5 years ago
Remove nsCSSPropList.h and nsCSSPropAliasList.h
Categories
(Core :: CSS Parsing and Computation, enhancement)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla61
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | fixed |
People
(Reporter: xidorn, Assigned: xidorn)
References
(Blocks 1 open bug)
Details
Attachments
(5 files)
|
59 bytes,
text/x-review-board-request
|
heycam
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
heycam
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
heycam
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
heycam
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
heycam
:
review+
|
Details |
That list contains lots of bits which should only be useful for the old style system. We should investigate what dependencies left on them.
|
Assignee | |
Updated•5 years ago
|
Depends on: 1452542
Summary: Investigate what information we can drop from nsCSSPropList.h → Remove nsCSSPropList.h
|
|
Assignee | |
Updated•5 years ago
|
Summary: Remove nsCSSPropList.h → Remove nsCSSPropList.h and nsCSSPropAliasList.h
|
|
Assignee | |
Updated•5 years ago
|
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 6•5 years ago
|
||
| mozreview-review | ||
Comment on attachment 8971869 [details] Bug 1448759 part 1 - Make KTableEntry an independent type. https://reviewboard.mozilla.org/r/240612/#review246292 ::: layout/style/nsCSSProps.h:34 (Diff revision 1) > - typedef mozilla::CSSEnabledState EnabledState; > - typedef mozilla::CSSPropFlags Flags; > - > - struct KTableEntry > - { > +{ > - // KTableEntry objects can be initialized either with an int16_t value > + // KTableEntry objects can be initialized either with an int16_t value Update the name here.
Attachment #8971869 -
Flags: review?(cam) → review+
|
|
||
Comment 7•5 years ago
|
||
| mozreview-review | ||
Comment on attachment 8971870 [details] Bug 1448759 part 2 - Have nsStyleUtil::AppendBitmaskCSSValue take a keyword table directly. https://reviewboard.mozilla.org/r/240614/#review246294
Attachment #8971870 -
Flags: review?(cam) → review+
|
|
||
Comment 8•5 years ago
|
||
| mozreview-review | ||
Comment on attachment 8971871 [details] Bug 1448759 part 3 - Remove kKeywordTableTable and LookupPropertyValue. https://reviewboard.mozilla.org/r/240616/#review246296
Attachment #8971871 -
Flags: review?(cam) → review+
|
|
||
Comment 9•5 years ago
|
||
| mozreview-review | ||
Comment on attachment 8971872 [details] Bug 1448759 part 4 - Switch gAllSubpropTable to use generated ServoCSSPropList.h. https://reviewboard.mozilla.org/r/240618/#review246298 ::: layout/style/nsCSSProps.cpp:2206 (Diff revision 1) > #undef CSS_PROP_SHORTHAND > #undef CSS_PROP_LONGHAND > }; > > static const nsCSSPropertyID gAllSubpropTable[] = { > #define CSS_PROP_LIST_ONLY_COMPONENTS_OF_ALL_SHORTHAND This can be removed.
Attachment #8971872 -
Flags: review?(cam) → review+
|
|
Assignee | |
Comment 10•5 years ago
|
||
| mozreview-review-reply | ||
Comment on attachment 8971872 [details] Bug 1448759 part 4 - Switch gAllSubpropTable to use generated ServoCSSPropList.h. https://reviewboard.mozilla.org/r/240618/#review246298 > This can be removed. How can this be removed? The whole patch is there just because I find this line cannot be removed...
|
|
||
Comment 11•5 years ago
|
||
| mozreview-review | ||
Comment on attachment 8971873 [details] Bug 1448759 part 5 - Remove nsCSSPropList.h and nsCSSPropAliasList.h. https://reviewboard.mozilla.org/r/240620/#review246302 Hooray!
Attachment #8971873 -
Flags: review?(cam) → review+
|
|
||
Comment 12•5 years ago
|
||
| mozreview-review | ||
Comment on attachment 8971872 [details] Bug 1448759 part 4 - Switch gAllSubpropTable to use generated ServoCSSPropList.h. https://reviewboard.mozilla.org/r/240618/#review246306
|
|
||
Comment 13•5 years ago
|
||
| mozreview-review-reply | ||
Comment on attachment 8971872 [details] Bug 1448759 part 4 - Switch gAllSubpropTable to use generated ServoCSSPropList.h. https://reviewboard.mozilla.org/r/240618/#review246298 > How can this be removed? The whole patch is there just because I find this line cannot be removed... For some reason I skipped over the GenerateServoCSSPropList.py change so I thought we no longer had any use of this macro in ServoCSSPropList.h. Please ignore!
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 19•5 years ago
|
||
Pushed by xquan@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f57682050e8e part 1 - Make KTableEntry an independent type. r=heycam https://hg.mozilla.org/integration/autoland/rev/3d80ff8515b6 part 2 - Have nsStyleUtil::AppendBitmaskCSSValue take a keyword table directly. r=heycam https://hg.mozilla.org/integration/autoland/rev/0c1f6fcbcb39 part 3 - Remove kKeywordTableTable and LookupPropertyValue. r=heycam https://hg.mozilla.org/integration/autoland/rev/7ec44505efeb part 4 - Switch gAllSubpropTable to use generated ServoCSSPropList.h. r=heycam https://hg.mozilla.org/integration/autoland/rev/2784dccf11ec part 5 - Remove nsCSSPropList.h and nsCSSPropAliasList.h. r=heycam
|
||
Comment 20•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/f57682050e8e https://hg.mozilla.org/mozilla-central/rev/3d80ff8515b6 https://hg.mozilla.org/mozilla-central/rev/0c1f6fcbcb39 https://hg.mozilla.org/mozilla-central/rev/7ec44505efeb https://hg.mozilla.org/mozilla-central/rev/2784dccf11ec
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•