Closed
Bug 1448836
Opened 6 years ago
Closed 6 years ago
Directly call NumberToAtom in parser
Categories
(Core :: JavaScript Engine, enhancement, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla61
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | fixed |
People
(Reporter: anba, Assigned: anba)
Details
Attachments
(1 file)
|
4.27 KB,
patch
|
jorendorff
:
review+
|
Details | Diff | Splinter Review |
Parser.cpp defines DoubleToAtom which essentially boils down to calling NumberToAtom, only that DoubleToAtom is slower.
|
Assignee | |
Comment 1•6 years ago
|
||
Directly call NumberToAtom in Parser.cpp instead of going through ToAtom -> ToAtomSlow -> NumberToAtom. We can do almost the same in FoldConstants.cpp except that we also need to recover from OOM because |FoldElement| is infallible.
Attachment #8962367 -
Flags: review?(jorendorff)
|
||
Updated•6 years ago
|
Attachment #8962367 -
Flags: review?(jorendorff) → review+
|
|
||
Updated•6 years ago
|
Priority: -- → P3
|
|
Assignee | |
Comment 2•6 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2a512f2c1cfc6daddadcc34ea0207bcebd0a95f2
Keywords: checkin-needed
Pushed by cbrindusan@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/dce494e35759 Call NumberToAtom when argument is double value. r=jorendorff
Keywords: checkin-needed
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/dce494e35759
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•