Closed
Bug 1448837
Opened 6 years ago
Closed 6 years ago
Remove code to handle already assigned inferred name from BytecodeEmitter
Categories
(Core :: JavaScript Engine, enhancement, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla61
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | fixed |
People
(Reporter: anba, Assigned: anba)
References
Details
Attachments
(1 file, 1 obsolete file)
|
7.15 KB,
patch
|
anba
:
review+
|
Details | Diff | Splinter Review |
https://searchfox.org/mozilla-central/rev/003262ae12ce937950ffb8d3b0fa520d1cc38bff/js/src/frontend/BytecodeEmitter.cpp#5493-5495 > // Single node can be emitted multiple times if it appears in > // array destructuring default. If function already has a name, > // just return. That comment and its corresponding code should be obsolete since bug 1322314.
|
Assignee | |
Comment 1•6 years ago
|
||
IIRC the check in BytecodeEmitter.cpp is no longer necessary because of the changes in bug 1322314. If that's correct we can also modify NameToFunctionName, now that it is only called in JSFunction.cpp, to take a HandleValue instead of a JSAtom* parameter which enables us to skip one call to ToAtom if |prefixKind != FunctionPrefixKind::None|.
Attachment #8962370 -
Flags: review?(arai.unmht)
|
||
Comment 2•6 years ago
|
||
Comment on attachment 8962370 [details] [diff] [review] bug1448837.patch Review of attachment 8962370 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!
Attachment #8962370 -
Flags: review?(arai.unmht) → review+
|
||
Updated•6 years ago
|
Priority: -- → P3
|
|
Assignee | |
Comment 3•6 years ago
|
||
Updated to apply cleanly on inbound, carrying r+.
Attachment #8962370 -
Attachment is obsolete: true
Attachment #8963102 -
Flags: review+
|
|
Assignee | |
Comment 4•6 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2a512f2c1cfc6daddadcc34ea0207bcebd0a95f2
Keywords: checkin-needed
Pushed by nbeleuzu@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/4cd76f6e6217 Remove code to handle already set name now that parse nodes can no longer be emitted twice. r=arai
Keywords: checkin-needed
|
||
Comment 6•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/4cd76f6e6217
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•