144884 - Necko buffer management

Status: VERIFIED FIXED

(Core :: Networking, defect)

Description

[Suresh Duddi (gone)]

It would good for the pipe to recyle its buffers. Will reduce memory allocation
churn.

Comment 1

[Suresh Duddi (gone)]

cache, http, ftp buffers are not recycled. We allocate and free them. Esp. ftp
is allocating 64k buffers.

Comment 2

[Suresh Duddi (gone)]

Attachment: 4k buffer cache in necko

All data txfrs with 4k segment size will get buffers from the buffer cache.

Comment 3

[Darin Fisher]

Comment on attachment 84832 [details] [diff] [review]
4k buffer cache in necko

sr=darin (looks good to me!)

Comment 4

[Suresh Duddi (gone)]

Attachment: Using CreateInstance to make the allocator object

Comment 5

[Darin Fisher]

Comment on attachment 86446 [details] [diff] [review]
Using CreateInstance to make the allocator object

sr=darin

Comment 6

[Suresh Duddi (gone)]

Attachment: Tip patch + included nsNetModule.cpp change to release the allocator.

Comment 7

[Suresh Duddi (gone)]

Comment on attachment 89856 [details] [diff] [review]
Tip patch + included nsNetModule.cpp change to release the allocator.

Darin looked at this. Moving sr from earlier patch.

Comment 8

[Robert John Churchill]

Comment on attachment 89856 [details] [diff] [review]
Tip patch + included nsNetModule.cpp change to release the allocator.

r=rjc

Comment 9

[Suresh Duddi (gone)]

Fix checked in to trunk.

Comment 10

[benc]

VERIFIED via bonsai:

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=nsIOService.cpp&root=/cvsroot&subdir=mozilla/netwerk/base/src&command=DIFF_FRAMESET&rev1=1.145&rev2=1.146

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=nsIOService.h&root=/cvsroot&subdir=mozilla/netwerk/base/src&command=DIFF_FRAMESET&rev1=1.40&rev2=1.41

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/netwerk/build&command=DIFF_FRAMESET&file=nsNetModule.cpp&rev1=1.69&rev2=1.70&root=/cvsroot