1448911 - It takes a very long time for local files to be invalidated as Top Site image URLs

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P2)

Description

[Ciprian Muresan [:cmuresan], Ecosystem QA]

Attachment: take a long while for local files to be invalidated.gif

[Affected versions]:
- Nightly 61.0a1

[Affected Platforms]:
- All Windows
- All Mac
- All Linux

[Prerequisites]:
- Have a clean new Firefox profile.

[Steps to reproduce]:
1. Start the browser with the prerequisites from prerequisites and open an image from your local drive.
2. Copy the URL and open a new tab.
3. Edit a Top Site and click the "Use a custom image..." link.
4. Paste the URL from Step 2 and click "Preview".
5. Observe the behavior.

[Expected result]:
- The "Valid URL required" message is displayed instantly.

[Actual results]:
- The "Image failed to load. Try a different URL." message is displayed after a while.

[Notes]:
- This issue is also reproducible if you write a random string in the Image URL field and press Preview.
- Attached a screen recording of the issue.

Comment 1

[Tim Spurway [:tspurway]]

Let's make 'file://' URLs invalid

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4061

Comment 3

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/93a05af13d001c1e1a12ffb407c9758e3290b516
Fix Bug 1448911 - Allow only http/https in URL fields

This will also fix bug 1423329

Comment 4

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/3a5cfad58dd8

Comment 5

[Ciprian Muresan [:cmuresan], Ecosystem QA]

Build ID 	20180412001050
User Agent 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0


The issue is no longer reproducible on the latest Nightly on Windows 10 x64, Mac 10.13.3 and Arch Linux. Local files are now instantly invalidated.