Intro to tracking protection is shown 20 times

RESOLVED FIXED in Firefox 68

Status

()

enhancement
P3
normal
RESOLVED FIXED
a year ago
a month ago

People

(Reporter: mkaply, Assigned: nimbus2020b, Mentored)

Tracking

Trunk
Firefox 68
Points:
---

Firefox Tracking Flags

(firefox61 affected, firefox68 fixed)

Details

Attachments

(1 attachment)

Johann, any thoughts as to the priority of this?
Flags: needinfo?(jhofmann)
(In reply to Mike Kaply [:mkaply] from comment #0)
> We currently show the tracking protection intro 20 times because of this
> code:
> 
> https://searchfox.org/mozilla-central/source/browser/base/content/browser-
> trackingprotection.js#7
> 
> That seems a little excessive. Should we pick a lower value?

I agree it could be lower, maybe 5? I don't feel strongly about this either though, maybe pdol knows someone who can give us a qualified opinion here :)

> As a side note, why does screenshots seem to set this value as well?
> 
> https://searchfox.org/mozilla-central/source/browser/tools/mozscreenshots/
> mozscreenshots/extension/configurations/ControlCenter.jsm#221
> https://searchfox.org/mozilla-central/source/browser/tools/mozscreenshots/
> mozscreenshots/extension/configurations/ControlCenter.jsm#235

That's so that the intro does not appear when making the screenshots of the control center, IIRC. It's testing only, anyway.

(In reply to François Marier [:francois] from comment #1)
> Johann, any thoughts as to the priority of this?

P3 or P5, let's say P3 for now.
Flags: needinfo?(jhofmann) → needinfo?(pdolanjski)
Priority: -- → P3
We're going to be redesigning this UI and onboarding anyways, so I'd almost suggest we wontfix this.
Flags: needinfo?(pdolanjski)
Priority: P3 → P5

This is defined here nowadays: https://searchfox.org/mozilla-central/rev/56705678f5fc363be5e0237e1686f619b0d23009/browser/base/content/browser-contentblocking.js#745-746

Technically this task would only be about changing the number to, say, 5, but it would also be nice to have a pref for controlling this.

Priority: P5 → P3
Mentor: jhofmann
(Assignee)

Comment 5

2 months ago

(In reply to Johann Hofmann [:johannh] from comment #4)

This is defined here nowadays: https://searchfox.org/mozilla-central/rev/56705678f5fc363be5e0237e1686f619b0d23009/browser/base/content/browser-contentblocking.js#745-746

Technically this task would only be about changing the number to, say, 5, but it would also be nice to have a pref for controlling this.

I want to work on this issue. Please assign it to me.

Done, thank you!

Assignee: nobody → nimbus2020b
Status: NEW → ASSIGNED
(Assignee)

Comment 7

2 months ago

replaced MAX_INTROS constant value of 20 with pref set to 5

Hi Nidhi, are you still working on this? Is there anything I can help you with?

Flags: needinfo?(nimbus2020b)
(Assignee)

Comment 9

a month ago

Sorry, Johann! I have been busy with college. Just submitted a revision on phabricator.

Flags: needinfo?(nimbus2020b)

Comment 10

a month ago
Pushed by jhofmann@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/701cbec1b236
Added: Prefs for tracking protection intro r=johannh

Comment 11

a month ago
bugherder
Status: ASSIGNED → RESOLVED
Last Resolved: a month ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
You need to log in before you can comment on or make changes to this bug.