Closed Bug 1448936 Opened 6 years ago Closed 6 years ago

Remove server side logging code from actor codebase

Categories

(DevTools :: Console, enhancement)

enhancement
Not set
normal

Tracking

(firefox61 fixed)

RESOLVED FIXED
Firefox 61
Tracking Status
firefox61 --- fixed

People

(Reporter: ochameau, Assigned: bgrins)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Server logging is now supported via a web extension [1].
if we don't want to expose that in the new console frontend, we shoud probably remove the actor code related to that. But we should also keep it until the old console frontend (that still supports it) is removed.

This code is mostly in these modules:
https://searchfox.org/mozilla-central/source/devtools/shared/webconsole/server-logger.js
https://searchfox.org/mozilla-central/source/devtools/shared/webconsole/server-logger-monitor.js

Used from the webconsole actor:
https://searchfox.org/mozilla-central/rev/003262ae12ce937950ffb8d3b0fa520d1cc38bff/devtools/server/actors/webconsole.js#23


[1] https://addons.mozilla.org/en-US/firefox/addon/chromelogger/
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Comment on attachment 8967822 [details]
Bug 1448936 - Remove unused server side logging code;

https://reviewboard.mozilla.org/r/236510/#review242306

Looks good, thanks! :)
Attachment #8967822 - Flags: review?(jryans) → review+
Pushed by bgrinstead@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e56d07b87ddb
Remove unused server side logging code;r=jryans
https://hg.mozilla.org/mozilla-central/rev/e56d07b87ddb
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.