1448937 - Upgrade Phabricator to week 2018/12

Status: RESOLVED FIXED

(Conduit :: Infrastructure, enhancement)

Description

[David Lawrence [:dkl]]

https://wiki.mozilla.org/Phabricator/UpgradeProcess

Comment 1

[Phabricator Automation]

Attachment: Upgrade - Promote 2018 Week 12

Comment 2

[David Lawrence [:dkl]]

(In reply to Chris Hartjes [:grumpy][:chartjes] from comment #2)
> QA performed tests and all passed except for the "Reclaiming a revision
> unobsoletes the attachment"
> 
> * no visual cue as to the revision being obsolete
> * no option in the 'Add Action' dropdown to allow for reclaiming the revision

I have tested this on phabricator-dev.allizom.org with success. I was able to:

1. Create new revision with bug id
2. View the new attachment created in the bug id
3. Abandon the revision
4. View the attachment obsoleted in the bug
5. Choose 'Reclaim revision' in the action menu and reopen the revision.
6. View the old attachment be un-obsoleted in the same bug.

Are these similar to the steps you took?

dkl

Comment 3

[Chris Hartjes [:grumpy][:chartjes]]

:dkl

Those are the exact steps I took. During previous testing I could follow that exactly. This time I do not see any visual cue that an attachment has been made obsolete and there is no option for me to reclaim the revision.

Comment 4

[David Lawrence [:dkl]]

(In reply to Chris Hartjes [:grumpy][:chartjes] from comment #3)
> :dkl
> 
> Those are the exact steps I took. During previous testing I could follow
> that exactly. This time I do not see any visual cue that an attachment has
> been made obsolete and there is no option for me to reclaim the revision.

You should see the "Reclaim Revision" option in the drop down action list if you are the author of the revision. I don't believe non-authors will see that choice.

Also on the bug view side, you should see that attachment when clicking the "Show Obsoleted" button under the attachment list if the revision is abandoned and also the attachment should reappear when reclaimed. In the bug history (comments) below you should also see:

Attachment #<attachid> - Attachment is obsolete: true (if false)

which are made by the Phabricator Automation user.

Which bug id is the one you were testing with so I can see what happened?

dkl

Comment 5

[Chris Hartjes [:grumpy][:chartjes]]

After doing that testing step again, I was able to confirm that abandoning and reclaiming a revision works as expected.

QA validates this deployment

Comment 6

[David Lawrence [:dkl]]

Done