Closed Bug 1449034 Opened 6 years ago Closed 6 years ago

Update Rust crates to use lazy_static 1.0

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set
normal

Tracking

(firefox61 fixed)

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: mbrubeck, Assigned: mbrubeck)

Details

Attachments

(1 file)

This patch updates our last few dependencies from lazy_static 0.2 to lazy_static 1.0.
I have a patch for this locally, but it causes linker errors on my Linux system:

 0:01.11 force-cargo-library-build
 0:01.81    Compiling libudev-sys v0.1.4
 0:02.88    Compiling libudev v0.2.0
 0:03.47    Compiling u2fhid v0.1.0 (file:///home/mbrubeck/src/mozilla-central/dom/webauthn/u2f-hid-rs)
 0:04.25    Compiling gkrust-shared v0.1.0 (file:///home/mbrubeck/src/mozilla-central/toolkit/library/rust/shared)
 0:07.85    Compiling gkrust v0.1.0 (file:///home/mbrubeck/src/mozilla-central/toolkit/library/rust)
 0:14.80     Finished dev [optimized + debuginfo] target(s) in 12.98 secs
 0:15.18 libxul.so
 1:02.98 /home/mbrubeck/src/mozilla-central/third_party/rust/libudev/src/monitor.rs:51: error: undefined reference to 'udev_monitor_filter_add_match_subsystem_devtype'
 1:02.98 /home/mbrubeck/src/mozilla-central/third_party/rust/libudev/src/enumerator.rs:49: error: undefined reference to 'udev_enumerate_add_match_subsystem'
 1:02.98 third_party/rust/libudev/src/device.rs:28: error: undefined reference to 'udev_device_unref'
 1:02.98 third_party/rust/libudev/src/device.rs:51: error: undefined reference to 'udev_device_get_is_initialized'
 1:02.98 third_party/rust/libudev/src/device.rs:57: error: undefined reference to 'udev_device_get_devnum'
 1:02.98 third_party/rust/libudev/src/device.rs:70: error: undefined reference to 'udev_device_get_syspath'
 1:02.98 third_party/rust/libudev/src/device.rs:80: error: undefined reference to 'udev_device_get_devpath'
 1:02.98 third_party/rust/libudev/src/device.rs:89: error: undefined reference to 'udev_device_get_devnode'
This is because I didn't update our locally-patched version of libudev-sys.
Comment on attachment 8962549 [details]
Bug 1449034 - Update Rust crates to use lazy_static 1.0.

https://reviewboard.mozilla.org/r/231350/#review237014
Attachment #8962549 - Flags: review?(ted) → review+
Pushed by mbrubeck@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3669520c8aa4
Update Rust crates to use lazy_static 1.0. r=ted
https://hg.mozilla.org/mozilla-central/rev/3669520c8aa4
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.